Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cmd/snap: install *.snap and *.snap.* as files too #908
Conversation
niemeyer
added some commits
Apr 12, 2016
|
retest this please |
zyga
reviewed
Apr 12, 2016
| - if strings.Contains(x.Positional.Snap, "/") { | ||
| - uuid, err = cli.InstallSnapFile(x.Positional.Snap) | ||
| + name := x.Positional.Snap | ||
| + if strings.Contains(name, "/") || strings.HasSuffix(name, ".snap") || strings.Contains(name, ".snap.") { |
niemeyer
Apr 12, 2016
Contributor
Common ending for repeated browser downloads and the such (foo.snap.1, etc). Cannot be ambiguous with a real snap name, due to the two dots.
chipaca
Apr 13, 2016
Member
@niemeyer note chrome adds (n) to the filename, e.g. http.chipaca_4.66920_all (1).snap
|
+1, just one question |
|
retest this please |
|
|
|
retest this please |
mvo5
merged commit ed1ce38
into
snapcore:master
Apr 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
niemeyer commentedApr 12, 2016
No description provided.