interfaces/apparmor: remove unused apparmor variables #933

Merged
merged 1 commit into from Apr 14, 2016

Conversation

Projects
None yet
3 participants
Contributor

zyga commented Apr 13, 2016

This patch removes unused apparmor variables APP_ID_DBUS and
APP_PKGNAME_DBUS which also removes the need to use .Developer in any
apparmor profile content.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

interfaces/apparmor: remove unused apparmor variables
This patch removes unused apparmor variables APP_ID_DBUS and
APP_PKGNAME_DBUS which also removes the need to use .Developer in any
apparmor profile content.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Collaborator

mvo5 commented Apr 14, 2016

👍

Contributor

jdstrand commented Apr 14, 2016

Not sure why these are being removed now since we will have to add them immediately back for the bluez policy.

Contributor

zyga commented Apr 14, 2016

@jdstrand because bluez can use other variables. We cannot use .developer in any profile and we should not use .revision either. If you do that then you end up with one of the existing variables.

Contributor

jdstrand commented Apr 14, 2016

Note that .Developer isn't needed any more since this variables are the dbusified versions of the profile name (ie, what we substitute for ###PROFILEATTACH###). Please feel free to instead move these into modernVariables with an appropriate name.

Contributor

zyga commented Apr 14, 2016

@jdstrand ack, I'll land this branch, remove legacy variables and switch everything to modern variables. Sounds good?

Contributor

jdstrand commented Apr 14, 2016

That sounds fine.

@zyga zyga merged commit 12b9b22 into snapcore:master Apr 14, 2016

3 of 4 checks passed

Integration tests
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 76.879%
Details

@zyga zyga deleted the zyga:ifaces-kill-developer branch Dec 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment