Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging/{ubuntu,debian}: add liblzo2-dev as a dependency for building snapd #9470

Merged
merged 1 commit into from Oct 7, 2020

Conversation

anonymouse64
Copy link
Member

This is necessary to build squashfuse/snapfuse with lzo compression support,
which is necessary for snaps that now use lzo compression.

Not updating the non-ubuntu and non-debian package dependencies for now, as it's
unclear that using snapd inside non-ubuntu lxd containers is expected to work,
and that's the only known use-case for snapfuse right now.

Also update the lxd-snapfuse spread test to check that we can use lzo compressed
snaps inside an ubuntu lxd container now too.

…ng snapd

This is necessary to build squashfuse/snapfuse with lzo compression support,
which is necessary for snaps that now use lzo compression.

Not updating the non-ubuntu and non-debian package dependencies for now, as it's
unclear that using snapd inside non-ubuntu lxd containers is expected to work,
and that's the only known use-case for snapfuse right now.

Also update the lxd-snapfuse spread test to check that we can use lzo compressed
snaps inside an ubuntu lxd container now too.

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
@anonymouse64 anonymouse64 added Simple 😃 A small PR which can be reviewed quickly Bug labels Oct 6, 2020
@anonymouse64 anonymouse64 requested a review from mvo5 October 6, 2020 18:07
@mvo5 mvo5 added the ⚠ Critical High-priority stuff (e.g. to fix master) label Oct 6, 2020
@mvo5 mvo5 added this to the 2.47 milestone Oct 6, 2020
Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! Also for adding the test!

Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvo5 mvo5 merged commit 0d33543 into snapcore:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠ Critical High-priority stuff (e.g. to fix master) Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
3 participants