/snapd

overlord/ifacestate: reload snap connections when setting up security for a given snap #950

Merged
merged 9 commits into from Apr 14, 2016
+54 −10

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zyga @niemeyer
@zyga
Contributor

zyga commented Apr 14, 2016

This branch ensures that a connection that was established is kept around when setup-snap-security is used.

zyga added some commits Apr 14, 2016

@zyga
overlord/ifacestate: fix addSetupSnapSecurityChange to use snapName 
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
c7c8b19
@zyga
interfaces/overlord: create setupSecurity helper and use it 
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
1a70abe
@zyga
overlord/ifacestate: allow reloadConnections to be scoped to a single… 
… snap

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
0ebe7ad
@zyga
overlord/ifacestate: use setupSecurity in doSetupSnapSecurity 
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
6dbd0a0
@zyga
overlord/ifacestate: reload snap connections in do-setup-security 
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

All checks have passed

4 successful checks
@snappy-m-o
Integration tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.02%) to 76.819%
Details
1c9343f
@zyga
Merge branch 'overlord-connect-disconnect-setup-security' into overlo… 
…rd-setup-reconnects

Some checks were not successful

2 failing and 2 successful checks
@snappy-m-o
Integration tests
Details
@snappy-m-o
autopkgtest
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.007%) to 76.83%
Details
4ec904b
@zyga
Merge branch 'overlord-connect-disconnect-setup-security' into overlo… 
…rd-setup-reconnects

Some checks were not successful

2 failing and 2 successful checks
@snappy-m-o
Integration tests
Details
@snappy-m-o
autopkgtest
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.07%) to 76.902%
Details
d99018b
@zyga
Merge branch 'overlord-connect-disconnect-setup-security' into overlo… 
…rd-setup-reconnects

All checks have passed

3 successful checks
@snappy-m-o
Integration tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
6c31a57
@zyga
Merge branch 'master' into overlord-setup-reconnects

All checks have passed

4 successful checks
@snappy-m-o
Integration tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.002%) to 76.96%
Details
de658c8
overlord/ifacestate/ifacemgr_test.go
@@ -336,6 +336,46 @@ func (s *interfaceManagerSuite) TestDoSetupSnapSecuirtyKeepsExistingConnectionSt
})
}
+func (s *interfaceManagerSuite) TestDoSetupSnapSecuirtyReloadsConnectionsWhenInvokedOnPlugSide(c *C) {
@niemeyer

niemeyer Apr 14, 2016 •
Edited 1 time

Contributor

LGTM, but let's please rename these function names to be at most half that len. Let's use comments to document them instead.

@niemeyer niemeyer merged commit 1d872aa into snapcore:master Apr 14, 2016
4 checks passed

4 checks passed

Integration tests Success
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 76.96%
Details

@zyga zyga deleted the zyga:overlord-setup-reconnects branch Dec 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment