/snapd

interfaces/apparmor: load all apparmor profiles on snap setup #962

Merged
merged 1 commit into from Apr 14, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zyga @niemeyer
@zyga
Contributor

zyga commented Apr 14, 2016 •
Edited 1 time

This patch ensures that each time we setup apparmor for aspecific snap
we load all profiles. This fixes the unlikely case when a profile is
not changed on disk because earlier setup already put it into place but
snapd was interrupted right before the profile is loaded into the kernel.

The task that contained the security setup will be re-tried and all
profiles will be correctly loaded.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com
@zyga
interfaces/apparmor: always load all apparmor profiles when setting u… 
…p a snap

This patch ensures that each time we setup apparmor for aspecific snap
we load all profiles. This fixes the unlikely case when a profile is
not changed on disk because earlier setup already put it into place but
snapd was interrupted right before the profile is loaded into the kernel.

The task that contained the security setup will be re-tried and all
profiles will be correctly loaded.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

All checks have passed

4 successful checks
@snappy-m-o
Integration tests — Success
Details
@snappy-m-o
autopkgtest — Success
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.01%) to 76.994%
Details
e368757
@niemeyer
Contributor

niemeyer commented Apr 14, 2016

retest this please

@niemeyer niemeyer changed the title from interfaces/apparmor: always load all apparmor profiles when setting u… to interfaces/apparmor: load all apparmor profiles on snap setup Apr 14, 2016

@niemeyer niemeyer merged commit a356a31 into snapcore:master Apr 14, 2016
4 checks passed

4 checks passed

Integration tests Success
Details
autopkgtest Success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 76.994%
Details

@zyga zyga deleted the zyga:ifaces-apparmor-loads-all-profiles branch Dec 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment