/snapweb

replace find vs findone #101

Merged
merged 3 commits into from Dec 1, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@AlexandreAbreu @dbarth @mvo5
@AlexandreAbreu
Contributor

AlexandreAbreu commented Nov 25, 2016

FindOne() has the right semantics for this, it does an exact search based on the name and in the store
replace find vs findone

Some checks were not successful

1 failing and 1 successful checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage increased (+5.9%) to 66.753%
Details
3cc5d77
@dbarth

dbarth commented Nov 28, 2016

Makes sense afaict.
Check the go test failures also.
@dbarth

dbarth commented Nov 28, 2016

@mvo5 can you confirm that the FindOne API is a good choice (current, deprecated?) ? Thanks
Tests

Some checks were not successful

1 failing and 1 successful checks
coverage/coveralls — Coverage decreased (-0.08%) to 60.759%
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
78768ef
@mvo5
Contributor

mvo5 commented Dec 1, 2016

Yes, AFAICS in your code, this is what you want to use.
@mvo5
Contributor

mvo5 commented Dec 1, 2016

👍
Merge master

Some checks were not successful

1 failing and 1 successful checks
coverage/coveralls — Coverage decreased (-0.08%) to 60.806%
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
11eba89

@dbarth dbarth merged commit 9546f41 into snapcore:master Dec 1, 2016
1 of 2 checks passed

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.08%) to 60.806%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment