Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add configure files as part of the sync #46
Conversation
sergiocazzolato
requested review from
stolowski and
mvo5
Sep 25, 2017
zyga
approved these changes
Sep 26, 2017
I think this was already addressed by mvo's PR that landed in snapd master but separately +1
sergiocazzolato
merged commit 752747e
into
snapcore:snapd-vendor-sync
Oct 2, 2017
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build could not complete due to an error
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sergiocazzolato commentedSep 25, 2017
Currently the files named "configure" are not sent to the syc-vendor
repo because configure name is on the .ignore file and prevents that
those files are added as part of the commits.
There are several files which were not copied so far:
./tests/lib/snaps/config-versions-v2/meta/hooks/configure
./tests/lib/snaps/config-versions/meta/hooks/configure
./tests/lib/snaps/snapctl-hooks/meta/hooks/configure
./tests/lib/snaps/basic-hooks/meta/hooks/configure
./tests/lib/snaps/snapctl-hooks-v2/meta/hooks/configure
./tests/lib/snaps/failing-config-hooks/meta/hooks/configure
./tests/lib/snaps/test-snapd-with-configure/meta/hooks/configure
./tests/lib/snaps/snapctl-from-snap/meta/hooks/configure
./tests/lib/snaps/snap-hooks/meta/hooks/configure