Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Adding commits information on snapd-vendor launchpad repo #48
Conversation
sergiocazzolato
and others
added some commits
Oct 2, 2017
sergiocazzolato
requested review from
stolowski and
mvo5
Oct 3, 2017
sergiocazzolato
added some commits
Oct 3, 2017
sergiocazzolato
requested review from
niemeyer and
zyga
Oct 3, 2017
added some commits
Oct 4, 2017
mvo5
reviewed
Oct 4, 2017
Maybe it is the jetlag speaking here (if so, sorry!). But I don't see what this branch is doing, I don't any information added to the branch here. Is there a commit missing or something?
|
@mvo5 it is just copying the commits file from the snapd-vendor repo to the new one that contains the changes from github. The commits file which contains the match between architecture built and commit hash is only in the snapd-vendor repo. |
|
@mvo5 once we have all these 3 PRs approved don't merge them please, I'll make an E2E test to validate everything is working properly. Tx |
| - mkdir -p $TARGET_DIR && mv /tmp/$TARGET_DIR/.git $TARGET_DIR && rm -rf /tmp/$TARGET_DIR | ||
| + mkdir -p $TARGET_DIR | ||
| + mv /tmp/$TARGET_DIR/.git $TARGET_DIR | ||
| + mv /tmp/$TARGET_DIR/commits $TARGET_DIR || true |
stolowski
Oct 5, 2017
Is it OK if the commits file is missing? Isn't it it going to fail at a later stage when we need commit id?
sergiocazzolato
Oct 5, 2017
Contributor
It will miss until the branch lp-buidl-core is executed and creates that. Ideally, it will miss just once.
I'll work on some documentation to make sure the whole process is clear.
Thanks for reviewing
and others
added some commits
Oct 5, 2017
niemeyer
requested changes
Oct 23, 2017
I also don't understand what's going on there, and considering that neither @mvo5 nor @stolowski do either, we should probably talk about this.
|
@niemeyer I have written this topic to explain how these two PRs will work together. Please tell me if it helps to understand the idea of this change. |
sergiocazzolato commentedOct 3, 2017
The idea is to add commits information on the launchpad repository,
which is gonna be used to keep tracking between the code on master and
the code used to build a core snap on edge channel.
This change will be used be another which is comming soon.