Adding commits information on snapd-vendor launchpad repo #48

Closed
wants to merge 52 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

sergiocazzolato commented Oct 3, 2017

The idea is to add commits information on the launchpad repository,
which is gonna be used to keep tracking between the code on master and
the code used to build a core snap on edge channel.

This change will be used be another which is comming soon.

sergiocazzolato and others added some commits Oct 2, 2017

Adding commits information on snapd-vendor launchpad repo
The idea is to add commits information on the launchpad repository,
which is gonna be used to keep tracking between the code on master and
the code used to build a core snap on edge channel.
This change will be used be another which is comming soon.
Adding commits information on snapd-vendor launchpad repo
The idea is to add commits information on the launchpad repository,
which is gonna be used to keep tracking between the code on master and
the code used to build a core snap on edge channel.
This change will be used be another which is comming soon.
Adding commits information on snapd-vendor launchpad repo
The idea is to add commits information on the launchpad repository,
which is gonna be used to keep tracking between the code on master and
the code used to build a core snap on edge channel.

This change will be used be another which is comming soon.
Adding commits information on snapd-vendor launchpad repo
The idea is to add commits information on the launchpad repository,
which is gonna be used to keep tracking between the code on master and
the code used to build a core snap on edge channel.

This change will be used be another which is comming soon.

@sergiocazzolato sergiocazzolato requested review from stolowski and mvo5 Oct 3, 2017

@sergiocazzolato sergiocazzolato requested review from niemeyer and zyga Oct 3, 2017

Maybe it is the jetlag speaking here (if so, sorry!). But I don't see what this branch is doing, I don't any information added to the branch here. Is there a commit missing or something?

Contributor

sergiocazzolato commented Oct 4, 2017

@mvo5 it is just copying the commits file from the snapd-vendor repo to the new one that contains the changes from github. The commits file which contains the match between architecture built and commit hash is only in the snapd-vendor repo.
It contains the "|| true" to address the scenario when the commits file does not exist.

Contributor

sergiocazzolato commented Oct 4, 2017

@mvo5, just to clarify, the 3 PRs which are alive #48 #49 #50 are part of the same change.

Contributor

sergiocazzolato commented Oct 4, 2017

@mvo5 once we have all these 3 PRs approved don't merge them please, I'll make an E2E test to validate everything is working properly.

Tx

- mkdir -p $TARGET_DIR && mv /tmp/$TARGET_DIR/.git $TARGET_DIR && rm -rf /tmp/$TARGET_DIR
+ mkdir -p $TARGET_DIR
+ mv /tmp/$TARGET_DIR/.git $TARGET_DIR
+ mv /tmp/$TARGET_DIR/commits $TARGET_DIR || true
@stolowski

stolowski Oct 5, 2017

Is it OK if the commits file is missing? Isn't it it going to fail at a later stage when we need commit id?

@sergiocazzolato

sergiocazzolato Oct 5, 2017

Contributor

It will miss until the branch lp-buidl-core is executed and creates that. Ideally, it will miss just once.
I'll work on some documentation to make sure the whole process is clear.
Thanks for reviewing

Snappy Developers and others added some commits Oct 5, 2017

I also don't understand what's going on there, and considering that neither @mvo5 nor @stolowski do either, we should probably talk about this.

Contributor

sergiocazzolato commented Oct 23, 2017

@niemeyer I have written this topic to explain how these two PRs will work together. Please tell me if it helps to understand the idea of this change.
https://forum.snapcraft.io/t/building-and-testing-the-core-snap-on-edge-channel/2419

sergiocazzolato added some commits Oct 24, 2017

Moving snapd-vendor-sync to nightly execution
The idea is to sync once a day and by doing that then it is easier to
match the code in snapd-vendor repo with the core snap in edge.

@sergiocazzolato sergiocazzolato deleted the sergiocazzolato:snapd-vendor-sync branch Oct 24, 2017

@sergiocazzolato sergiocazzolato restored the sergiocazzolato:snapd-vendor-sync branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment