Add fedora-25-64 image #2

Open
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

morphis commented Apr 27, 2017

No description provided.

Some comments

@@ -16,17 +16,24 @@ backends:
kernel: GRUB 2
- debian-unstable-64:
kernel: GRUB 2
+ - fedora-25-64
@zyga

zyga May 15, 2017

Do we need the kernel: GRUB 2 thing?

@morphis

morphis May 15, 2017

Contributor

No. Fedora doesn't boot with that one on Linode.

spread.yaml
path: /root/spread
restore: |
- apt autoremove -y
+ if [[ "$SPREAD_SYSTEM" = fedora-* ]]; then
@zyga

zyga May 15, 2017

Can you please switch/case here. It it will look more natural and will do everything we need. We also should not have a default / else case as it will always be wrong, just be explicit.

@morphis

morphis May 15, 2017

Contributor

Will do.

Looks good! a couple of questions

+ case "$SPREAD_SYSTEM" in
+ fedora-*)
+ dnf clean all -y
+ dnf clean metadata
@fgimenez

fgimenez May 15, 2017

Contributor

Doesn't dnf clean all imply dnf clean metadata ?

@morphis

morphis May 22, 2017

Contributor

In my tests I had to do a dnf clean metadata afterwards as there were still things lying around.

@fgimenez

fgimenez May 22, 2017

Contributor

Ok thanks, perhaps we should report this, according to http://dnf.readthedocs.io/en/latest/command_ref.html#clean-command-label clean all should.. well, clean all ;)

tasks/update/task.yaml
@@ -2,37 +2,41 @@ summary: Update Linode image.
execute: |
- case $SPREAD_REBOOT in
+ if [[ "$SPREAD_SYSTEM" = fedora-* ]]; then
+ dnf upgrade -y
@fgimenez

fgimenez May 15, 2017

Contributor

Couldn't we do some cleanup after rebooting into the new version as we do on ubuntu?

@morphis

morphis May 22, 2017

Contributor

Done.

spread.yaml
+ dnf clean metadata
+ find /var/log -type f -exec rm -f {} \;
+ ;;
+ debian-*)
@zyga

zyga May 16, 2017

Can you please use the far more familiar syntax debian-*|ubuntu-*)

@morphis

morphis May 22, 2017

Contributor

Done.

tasks/update/task.yaml
@@ -2,37 +2,41 @@ summary: Update Linode image.
execute: |
- case $SPREAD_REBOOT in
+ if [[ "$SPREAD_SYSTEM" = fedora-* ]]; then
@zyga

zyga May 16, 2017

Can you please use a switch/case statement here. In all the cases where we special case Fedora or Ubuntu the else part is always broken when we add something new.

@morphis

morphis May 22, 2017

Contributor

Done

zyga approved these changes May 22, 2017

+
+ uname -r > old-kernel
+
+ # apt update is hanging on security.ubuntu.com with IPv6.
@zyga

zyga May 22, 2017

Not related but we should eventually fix and remove this

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment