do not replace but prefix LD_LIBRARY_PATH #4

Merged
merged 1 commit into from Sep 1, 2017

Conversation

Projects
None yet
4 participants
Contributor

ogra1 commented Aug 26, 2017

The last fix to LD_LIBRARY_PATH was not enough (see https://dev.solus-project.com/T4390 ).

Instead of completely replacing the variable content we should just prefix it with the snap-delivered lib paths, so it can fall back to use available system libs (like libpcre.so.3 in the above bug)

zyga approved these changes Aug 26, 2017

+1

Member

Ads20000 commented Aug 28, 2017

Don't think we'd be able to fix this in stable because of this Issue with build.snapcraft.io. We're going to have to wait until 1.20 is released for the fix in stable (and to have builds from master going into edge rather than the betas which should really go in beta...)

Contributor

ogra1 commented Aug 28, 2017

pushing it to edge is fine, it is completely unusable on any non-ubuntu system currently, so i guess any channel is fine as long as this lands soon ...

Member

Ads20000 commented Aug 28, 2017

Oh right, presumably this is already usable on Ubuntu then? Hopefully someone like @popey is online and can merge? :) I don't have a non-Ubuntu OS available at the moment so I'll assume you've got this right xD

Contributor

ogra1 commented Aug 28, 2017

it is just a follow up to #3 which only fixed the issue partitally (leaving out system lib paths, which this commit adds back)

@flexiondotorg flexiondotorg merged commit c7c3db2 into snapcrafters:master Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment