When parsing attribute substitutions, a single $ stops regular "text gobbling", whereas Heist should look for the full ${ pattern #16

Closed
ozataman opened this Issue Jan 30, 2012 · 4 comments

Comments

Projects
None yet
2 participants
@ozataman
Member

ozataman commented Jan 30, 2012

Example:

Try putting the following regular html code (imagine the HTML braces there; github has issues with them)

<input type='text' value='This is just a value that has $ in it. But this part will never show, as $ will trigger attribute substitution and remove this entire part of this text'>

The resulting input node will only contain:

"This is just a value that has " in its value attribute.

@ozataman

This comment has been minimized.

Show comment
Hide comment
@ozataman

ozataman Jan 30, 2012

Member

Fixes the display issue - Github doesn't like html tags directly in text...

Member

ozataman commented Jan 30, 2012

Fixes the display issue - Github doesn't like html tags directly in text...

mightybyte added a commit that referenced this issue Feb 8, 2012

@mightybyte

This comment has been minimized.

Show comment
Hide comment
@mightybyte

mightybyte Feb 8, 2012

Member

Does this fix your problems?

Member

mightybyte commented Feb 8, 2012

Does this fix your problems?

@ozataman

This comment has been minimized.

Show comment
Hide comment
@ozataman

ozataman Feb 8, 2012

Member

Just glancing at it, it looks like it would! I'll give it a shot and get back to you.

Member

ozataman commented Feb 8, 2012

Just glancing at it, it looks like it would! I'll give it a shot and get back to you.

@mightybyte

This comment has been minimized.

Show comment
Hide comment
@mightybyte

mightybyte Dec 19, 2012

Member

0.10 fixes this

Member

mightybyte commented Dec 19, 2012

0.10 fixes this

@mightybyte mightybyte closed this Dec 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment