Blacklist hashable >= 1.2.0.0 && < 1.2.0.5 #164

Closed
23Skidoo opened this Issue Jan 5, 2013 · 9 comments

Projects

None yet

5 participants

@23Skidoo
Contributor
23Skidoo commented Jan 5, 2013

At the moment, hashable-1.2 generates consistent segfaults on some machines, on both Linux and Windows (tibbe/hashable#49). It'd be nice if this version could be temporarily blacklisted with a hashable < 1.2 constraint so that users weren't required to do it manually. The Yesod guys have already done it.

edit: The issue has been fixed in HEAD. Still may be worth it to blacklist hashable >= 1.2.0.0 && < 1.2.0.6.

@gregorycollins
Member

I'd prefer to wait a few days to see if @tibbe will fix the underlying problem. I just got back from vacation and don't see having enough cycles to put out a new release in the next few days anyways, maybe @mightybyte has time.

@tibbe
Contributor
tibbe commented Jan 5, 2013

I've released 1.2.0.3 which should address some of the issues. I'm working on the hashable issue the upcoming week.

@23Skidoo
Contributor
23Skidoo commented Jan 5, 2013

The segfault still happens with 1.2.0.3.

@tibbe
Contributor
tibbe commented Jan 5, 2013

I believe there were a few different ones. A few are fixed by 1.2.0.3. Still some more to go (tracked on the bug tracker).

@23Skidoo
Contributor
23Skidoo commented Jan 5, 2013

@tibbe I encountered two bugs:

  • SSE4.1 instructions in siphash-sse2.c - partially fixed in 1.2.0.3 by not enabling SSE4.1 by default (tibbe/hashable#50)
  • strange segfault in SSE2 code - still present in 1.2.0.3 (tibbe/hashable#49)
@hvr
Member
hvr commented Jan 9, 2013

Btw, would blacklisting hashable-1.2 as an afterthought work at all? I mean, wouldn't the cabal-install solver then just backtrack to to the previous version 0.9.2.N-1 which wasn't in conflict with hashable-1.2?

@23Skidoo
Contributor

The issue has been fixed in current HEAD (what will be 1.2.0.5, I believe) - see tibbe/hashable@e64484d and discussion in tibbe/hashable#49. At least on my machine, I don't get segfaults anymore. Still may be worth it to blacklist hashable >= 1.2.0.0 && < 1.2.0.5.

@aginiewicz

(just small note, 1.2.0.5 containing the fix is already released)

@23Skidoo
Contributor

Unfortunately, 1.2.0.5 contains another bug - see tibbe/hashable#60. 1.2.0.6, which contains the fix, was released yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment