Skip to content
This repository

``Readable Text`` doesn't decodeUri first before decodeUtf8 #175

Closed
MnO2 opened this Issue February 28, 2013 · 2 comments

3 participants

MnO2 Gregory Collins Doug Beardsley
MnO2

Browsing the source code, we found a problem with Readable Text instance
https://github.com/snapframework/snap-core/blob/master/src/Snap/Util/Readable.hs

That is it didn't use a decodeUri first before decodeUtf8.
Therefore with an example like this: https://gist.github.com/MnO2/5058390,
requesting /echo/中文 would fail.

Doug Beardsley
Owner

In the next major release, we should switch to use the instances from the readable package. Obviously we wouldn't call decodeUri from the readable package. So I think the solution is to put the decodeUri in pathArg and other appropriate places.

Gregory Collins
Gregory Collins gregorycollins closed this in f2ec889 February 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.