Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure with hashable 1.3.1.0 #303

Closed
felixonmars opened this issue Feb 23, 2021 · 3 comments
Closed

Test failure with hashable 1.3.1.0 #303

felixonmars opened this issue Feb 23, 2021 · 3 comments

Comments

@felixonmars
Copy link
Contributor

It passes with hashable 1.3.0.0 and others unchanged.

Snap.Util.CORS.Tests:
  CORS/simple: [OK]
  CORS/options: [Failed]
Header "Access-Control-Allow-Headers"
expected: Just "X-STUFF, Content-Type"
 but got: Just "Content-Type, X-STUFF"
@kozross
Copy link
Contributor

kozross commented May 30, 2021

This is due to the hash being unstable. I've sent a PR repairing this test, but in general, we shouldn't rely on any order we don't ourselves enforce.

Reference about hash instability.

@ysangkok
Copy link
Contributor

I think this can be closed since 94af153

@felixonmars
Copy link
Contributor Author

felixonmars commented Jun 9, 2022

Confirmed that the new version works fine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants