Conditional Typeable deriving for GHC versions. #184

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants

schell commented Nov 23, 2013

It looks like Data.Typeable no longer exports Typeable1 so I added some CPP conditions to make Snap.Internal.Types compile. My changes may be naive - please check! But snap-core now builds and installs for me on ghc7.7.2013.11.06.

Member

hvr commented Dec 3, 2013

I wonder why exactly the manual instance in 8ee59a2 was needed anyway... i.e. why couldn't hint handle the auto-derived one?

Hey @chowells79 -- is this the right thing to do here?

Owner

schell replied Jan 8, 2014

Would it be better to use #if __GLASGOW_HASKELL__ >= 707 ? It would achieve the same effect but wouldn't be effective for compiling with Hugs, me thinks.

Lots of stuff in snap isn't going to compile with things other than ghc. I think I'd use the __GLASGOW_HASKELL__ guard, since it's slightly easier to read. But either way, this is the right approach.

Contributor

phadej commented Mar 10, 2014

I guess this can be closed as master compiles with ghc 7.8?

Owner

gregorycollins commented Mar 10, 2014

Yeah someone else added the required code IIRC -- but could you verify it's fixed and close this if so?

Contributor

phadej commented Mar 10, 2014

It compiles with ghc-7.8.0.20140228 (rc2) for me. Couldn't test further as looks like that snap-server would require similar changes. And I cannot close other's PRs. :)

schell commented Mar 13, 2014

HEAD builds for me as well on ghc 7.8 rc2. Closing this PR.

schell closed this Mar 13, 2014

schell deleted the schell:compiling-under-ghc7.7 branch Mar 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment