Auth username format is inconsistent #67

Closed
tomcumming opened this Issue Jan 17, 2013 · 0 comments

Comments

Projects
None yet
2 participants

In regards to the Auth Snaplet

The createUser function takes a username as Text, but the loginByUsername function takes a username as a ByteString.

I can understand why the Snaplet would use ByteString to store usernames in an encoding-independent way. However, it might be nice for all functions to take a username input as a ByteString.

Alternatively, forcing Text for usernames throughout might be a good idea.

@mightybyte mightybyte added a commit that referenced this issue Mar 26, 2013

@mightybyte mightybyte Fix issue #67 c3abdcc

mightybyte closed this Mar 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment