Updated to work with lens 3.2 #55

Closed
wants to merge 60 commits into
from

Conversation

Projects
None yet
5 participants
Contributor

ekmett commented Nov 6, 2012

No description provided.

Should this also be fixed on master?

Owner

mightybyte replied Aug 11, 2012

Yeah, probably so. It was late...

Did you end up cherrypicking this back to 0.9?

Owner

mightybyte replied Aug 14, 2012

Just pushed it.

mightybyte and others added some commits Aug 17, 2012

Merge branch 'master' into 0.10
Conflicts:
	snap.cabal
Fixed issues #30 and #38, and add test
Modified createUser to check for empty usernames.
Fixed content tags in project template.
Merge pull request #42 from adinapoli/0.10
[0.10] Refactored App.hs and Tests.hs, removed Snap.Snaplet.Test
Merge pull request #43 from adinapoli/0.10
Beautified headings in App.hs and Tests.hs in test/suite/Blackbox
Get rid of SnapletHeist newtype
The previous implementation did not work for compiled splices and my attempts
at generalizing it to work with both interpreted and compiled splices all
failed.  In some ways this is better anyway because it means we're always
working in HeistT and don't have to deal with the pain of not having a
MonadHeist type class.
Merge pull request #45 from adinapoli/0.10
Removed any trace of wrapHandlers from Tutorial.lhs
Contributor

nurpax commented on 1c8ad9b Sep 25, 2012

I see that you're adding Either return type for createUser to return the error case for empty login/password.

createUser was previously potentially throwing DuplicateLogin exceptions in the case of duplicate logins error. Is the use of Either this way consistent with the previous error handling code? IOW, it looks inconsistent to mix both exceptions and Either this way. If you don't want to break the API, you perhaps add a new exception type for invalid login parameters?

This kind of code should prefer patterns like Either, and we shouldn't be throwing an exception from createUser either.

Re: API stability, Auth isn't yet widely used and I would prefer to make the API correct rather than freezing in a bad design.

mightybyte and others added some commits Sep 30, 2012

Merge pull request #47 from adinapoli/0.10
[0.10] Done type refactoring as discussed in issue #30
Merge pull request #49 from adinapoli/0.10
Removed any trace of exception throwing from function documentation
Merge pull request #50 from adinapoli/0.10
0.10 - createLogin yields the correct AuthFailure, fixed a subtle bug in registerUser
Merge branch 'master' into 0.10
Conflicts:
	project_template/default/foo.cabal
	snap.cabal
	test/snap-testsuite.cabal
Merge branch '0.10' of github.com:snapframework/snap into 0.10
Conflicts:
	snap.cabal
	test/snap-testsuite.cabal
Merge branch 'master' into 0.10
Conflicts:
	src/Snap/Snaplet/HeistNoClass.hs
	test/snap-testsuite.cabal
Contributor

ekmett commented Nov 6, 2012

This should have only contained my last couple of commits. I'm not quite sure how it added the entire history. Does someone who knows git better than I know what I did wrong?

Owner

gregorycollins commented Nov 6, 2012

Did you mean to make a pull request into the 0.10 branch?

Contributor

ekmett commented Nov 7, 2012

Yes. Please feel free to discard this and pull more appropriately.

@ekmett ekmett closed this Nov 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment