New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uniswap-v3] Add Pilot Protocol #4
Conversation
|
@anassohail99 Also i think it would make more sense to move the Uniswap v3 calculation to a more generic strategy, this strategy could be used by many others projects on Snapshot. |
@bonustrack Updated |
|
@anassohail99 Can you create a generic strategy with the name "uniswap-v3" just for the uniswap calculations? And do separated strategy "unipilot"? |
|
@anassohail99 Hey, Also update your fork branch with the latest changes from |
Co-authored-by: Chaitanya <yourchaitu@gmail.com>
|
@anassohail99 Please resolve conflicts, also would be good to install these two dependencies with |
|
@ChaituVR I've updated can you review it and merge it thanks. |
|
IMO there could be a comment somewhere explaining what options "tokenReserve" means. I understand that it's selecting the |
|
Strategy is live here: https://snapshot.org/#/strategy/uniswap-v3 |
Changes proposed in this pull request: