Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added strategy to give liquidity providers on the Ocean marketplace v… #113

Merged
merged 4 commits into from Feb 28, 2021
Merged

added strategy to give liquidity providers on the Ocean marketplace v… #113

merged 4 commits into from Feb 28, 2021

Conversation

w1kke
Copy link
Contributor

@w1kke w1kke commented Feb 27, 2021

…oting power

Fixes # .

Changes proposed in this pull request:

  • Add a strategy for Ocean Protocol to empower the liquidity providers on their marketplace to get voting power
  • Added the strategy to index.ts
  • Added a README.md that outlines what is being done in the strategy and possible ways to improve it in the future as well how to extend and test it

@bonustrack
Copy link
Member

@w1kke Hi! You must define the block number in your strategy like this:
https://github.com/snapshot-labs/snapshot.js/blob/master/src/strategies/balancer/index.ts#L44-L47
Otherwise it will only return the data in live, regardless of the proposal snapshot.

@w1kke
Copy link
Contributor Author

w1kke commented Feb 27, 2021

@bonustrack I added the parameter - but I have to cast to an int to comply with the subgraph API - so it is +snapshot

w1kke added a commit to w1kke/snapshot-spaces that referenced this pull request Feb 28, 2021
@w1kke
Add the ocean-marketplace strategy
ebee95d 
The strategy is currently in a pull request for Snapshot here:
snapshot-labs/snapshot.js#113
@w1kke w1kke mentioned this pull request Feb 28, 2021
Merged
bonustrack
bonustrack reviewed Feb 28, 2021
View reviewed changes
src/strategies/index.ts Outdated Show resolved Hide resolved
bonustrack
bonustrack approved these changes Feb 28, 2021
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bonustrack bonustrack merged commit 781a2eb into snapshot-labs:master Feb 28, 2021
gokaiorg added a commit to snapshot-labs/snapshot-spaces that referenced this pull request Mar 1, 2021
@anapheys @gokaiorg @w1kke
Adding a strategy to our Ocean Snapshot (#917)
14f16d2 
* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update index.json

* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update domains.json

* 2

2

* OceanDAO updates 3

OceanDAO updates 3

* Update spaces/oceandao/index.json

Co-authored-by: Gokai <jeremydouchamps@gmail.com>

* Update Logos

update logos

* add invalids

* Add the ocean-marketplace strategy

The strategy is currently in a pull request for Snapshot here:
snapshot-labs/snapshot.js#113

Co-authored-by: Gokai <jeremydouchamps@gmail.com>
Co-authored-by: Robin Lehmann <w1kke@users.noreply.github.com>
gokaiorg added a commit to snapshot-labs/snapshot-spaces that referenced this pull request Mar 2, 2021
@anapheys @gokaiorg @w1kke
Removing voting with OceanMarketplace Staked Tokens: Proper Vote Coun…
8211961 
…t not working (#925)

* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update index.json

* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update domains.json

* 2

2

* OceanDAO updates 3

OceanDAO updates 3

* Update spaces/oceandao/index.json

Co-authored-by: Gokai <jeremydouchamps@gmail.com>

* Update Logos

update logos

* add invalids

* Add the ocean-marketplace strategy

The strategy is currently in a pull request for Snapshot here:
snapshot-labs/snapshot.js#113

* Remove Ocean Marketplace strategy

Remove Ocean Marketplace strategy

Co-authored-by: Gokai <jeremydouchamps@gmail.com>
Co-authored-by: Robin Lehmann <w1kke@users.noreply.github.com>
gokaiorg added a commit to snapshot-labs/snapshot-spaces that referenced this pull request Mar 21, 2021
@idiom-bytes @anapheys
@gokaiorg @w1kke
Updating oceandao strategy, and migrating oceandao to officialoceanda…
ed8e929 
…o.eth (#1006)

* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update index.json

* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update domains.json

* 2

2

* OceanDAO updates 3

OceanDAO updates 3

* Update spaces/oceandao/index.json

Co-authored-by: Gokai <jeremydouchamps@gmail.com>

* Update Logos

update logos

* add invalids

* Add the ocean-marketplace strategy

The strategy is currently in a pull request for Snapshot here:
snapshot-labs/snapshot.js#113

* Remove Ocean Marketplace strategy

Remove Ocean Marketplace strategy

* Update index.json

* Fixed @w1kke ocendao strategy to include: erc20-balance-of + ocean-marketplace. Added oceandao => officialoceandao.eth alias so we can migrate votes+proposals from Snapshot Spaces to Snaphot ENS

Co-authored-by: Alex N <alexn@oceanprotocol.com>
Co-authored-by: anapheys <73855248+anapheys@users.noreply.github.com>
Co-authored-by: Gokai <jeremydouchamps@gmail.com>
Co-authored-by: Robin Lehmann <w1kke@users.noreply.github.com>
Co-authored-by: ralcantara <ralcantara@pop-os.localdomain>
Co-authored-by: idiom-bytes <idiom.bytes@gmail.com>
gokaiorg added a commit to snapshot-labs/snapshot-spaces that referenced this pull request Mar 23, 2021
@idiom-bytes @anapheys
@gokaiorg @w1kke
officialoceandao.eth ENS migration (#1009)
512307a 
* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update index.json

* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update domains.json

* 2

2

* OceanDAO updates 3

OceanDAO updates 3

* Update spaces/oceandao/index.json

Co-authored-by: Gokai <jeremydouchamps@gmail.com>

* Update Logos

update logos

* add invalids

* Add the ocean-marketplace strategy

The strategy is currently in a pull request for Snapshot here:
snapshot-labs/snapshot.js#113

* Remove Ocean Marketplace strategy

Remove Ocean Marketplace strategy

* Update index.json

* Fixed @w1kke ocendao strategy to include: erc20-balance-of + ocean-marketplace. Added oceandao => officialoceandao.eth alias so we can migrate votes+proposals from Snapshot Spaces to Snaphot ENS

* updating snapshot configuration according to gokaiorg latest recommendations to complete migration

Co-authored-by: Alex N <alexn@oceanprotocol.com>
Co-authored-by: anapheys <73855248+anapheys@users.noreply.github.com>
Co-authored-by: Gokai <jeremydouchamps@gmail.com>
Co-authored-by: Robin Lehmann <w1kke@users.noreply.github.com>
Co-authored-by: ralcantara <ralcantara@pop-os.localdomain>
fafrd pushed a commit to fafrd/snapshot-spaces that referenced this pull request Mar 23, 2021
@anapheys @gokaiorg @w1kke
Adding a strategy to our Ocean Snapshot (snapshot-labs#917)
f7e79bb 
* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update index.json

* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update domains.json

* 2

2

* OceanDAO updates 3

OceanDAO updates 3

* Update spaces/oceandao/index.json

Co-authored-by: Gokai <jeremydouchamps@gmail.com>

* Update Logos

update logos

* add invalids

* Add the ocean-marketplace strategy

The strategy is currently in a pull request for Snapshot here:
snapshot-labs/snapshot.js#113

Co-authored-by: Gokai <jeremydouchamps@gmail.com>
Co-authored-by: Robin Lehmann <w1kke@users.noreply.github.com>
fafrd pushed a commit to fafrd/snapshot-spaces that referenced this pull request Mar 23, 2021
@anapheys @gokaiorg @w1kke
Removing voting with OceanMarketplace Staked Tokens: Proper Vote Coun…
18dde81 
…t not working (snapshot-labs#925)

* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update index.json

* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update domains.json

* 2

2

* OceanDAO updates 3

OceanDAO updates 3

* Update spaces/oceandao/index.json

Co-authored-by: Gokai <jeremydouchamps@gmail.com>

* Update Logos

update logos

* add invalids

* Add the ocean-marketplace strategy

The strategy is currently in a pull request for Snapshot here:
snapshot-labs/snapshot.js#113

* Remove Ocean Marketplace strategy

Remove Ocean Marketplace strategy

Co-authored-by: Gokai <jeremydouchamps@gmail.com>
Co-authored-by: Robin Lehmann <w1kke@users.noreply.github.com>
fafrd pushed a commit to fafrd/snapshot-spaces that referenced this pull request Mar 23, 2021
@idiom-bytes @anapheys
@gokaiorg @w1kke
Updating oceandao strategy, and migrating oceandao to officialoceanda…
c7a0ae4 
…o.eth (snapshot-labs#1006)

* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update index.json

* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update domains.json

* 2

2

* OceanDAO updates 3

OceanDAO updates 3

* Update spaces/oceandao/index.json

Co-authored-by: Gokai <jeremydouchamps@gmail.com>

* Update Logos

update logos

* add invalids

* Add the ocean-marketplace strategy

The strategy is currently in a pull request for Snapshot here:
snapshot-labs/snapshot.js#113

* Remove Ocean Marketplace strategy

Remove Ocean Marketplace strategy

* Update index.json

* Fixed @w1kke ocendao strategy to include: erc20-balance-of + ocean-marketplace. Added oceandao => officialoceandao.eth alias so we can migrate votes+proposals from Snapshot Spaces to Snaphot ENS

Co-authored-by: Alex N <alexn@oceanprotocol.com>
Co-authored-by: anapheys <73855248+anapheys@users.noreply.github.com>
Co-authored-by: Gokai <jeremydouchamps@gmail.com>
Co-authored-by: Robin Lehmann <w1kke@users.noreply.github.com>
Co-authored-by: ralcantara <ralcantara@pop-os.localdomain>
Co-authored-by: idiom-bytes <idiom.bytes@gmail.com>
fafrd pushed a commit to fafrd/snapshot-spaces that referenced this pull request Mar 23, 2021
@idiom-bytes @anapheys
@gokaiorg @w1kke
officialoceandao.eth ENS migration (snapshot-labs#1009)
b278305 
* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update index.json

* OceanDAO-SnapshotCommit-1

OceanDAO-SnapshotCommit-1

* Update domains.json

* 2

2

* OceanDAO updates 3

OceanDAO updates 3

* Update spaces/oceandao/index.json

Co-authored-by: Gokai <jeremydouchamps@gmail.com>

* Update Logos

update logos

* add invalids

* Add the ocean-marketplace strategy

The strategy is currently in a pull request for Snapshot here:
snapshot-labs/snapshot.js#113

* Remove Ocean Marketplace strategy

Remove Ocean Marketplace strategy

* Update index.json

* Fixed @w1kke ocendao strategy to include: erc20-balance-of + ocean-marketplace. Added oceandao => officialoceandao.eth alias so we can migrate votes+proposals from Snapshot Spaces to Snaphot ENS

* updating snapshot configuration according to gokaiorg latest recommendations to complete migration

Co-authored-by: Alex N <alexn@oceanprotocol.com>
Co-authored-by: anapheys <73855248+anapheys@users.noreply.github.com>
Co-authored-by: Gokai <jeremydouchamps@gmail.com>
Co-authored-by: Robin Lehmann <w1kke@users.noreply.github.com>
Co-authored-by: ralcantara <ralcantara@pop-os.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@w1kke @bonustrack