Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AT => any: Allow opt-in while hidden from logged-out users #1550

Closed
vyv03354 opened this issue Nov 23, 2024 · 5 comments
Closed

AT => any: Allow opt-in while hidden from logged-out users #1550

vyv03354 opened this issue Nov 23, 2024 · 5 comments
Labels
feature Features and feature requests that are specific to Bridgy Fed, not fully described by the protocols.

Comments

@vyv03354
Copy link

Reported here (Japanese): https://bsky.app/profile/tukinet.info/post/3lb7e3a2gl22q

If "Discourage apps from showing my account to logged-out users" option is enabled, Bridgy Fed will not allow to start bridging. If the bridging is already started, however, posts will be bridged even if the option is checked. Is this an expected behavior? If it is not, please add a way to opt-in bridging even if the option is enabled, because the reported user desires the current behavior.

@Tamschi Tamschi added the feature Features and feature requests that are specific to Bridgy Fed, not fully described by the protocols. label Nov 24, 2024
@Tamschi
Copy link
Collaborator

Tamschi commented Nov 24, 2024

That's an interesting one. I think the behaviour is intentional, since hiding an account from logged-out users shouldn't just delete the fediverse bridge account (as that would sever all connections on ActivityPub).
However, it's not possible to translate the setting to ActivityPub, so for example Misskey instances can be used without login to view the account, if the handle is known.

Is it okay if I change the title to "AT => any: Allow opt-in while hidden from logged-out users", since this is a feature request?

@snarfed This could make sense with an --allow-logged-out-viewing flag added to the start command via DM. I don't think we should present that proactively in the help response, but we could surface it in #758 if this is why bridging fails.

@Tamschi
Copy link
Collaborator

Tamschi commented Nov 24, 2024

Oh, I just saw #1549! That makes this easier, I think.

Edit: And I only now saw #1549 (comment).
It makes sense, we'd need to filter those posts out of the Bridgy Fed status pages too.

@vyv03354
Copy link
Author

Is it okay if I change the title to "AT => any: Allow opt-in while hidden from logged-out users", since this is a feature request?

OK, I changed the title.

@Tamschi Tamschi changed the title AT => AP: Bridgy Fed bridges Bluesky posts even when "Discourage apps from showing my account to logged-out users" option is enabled if the account already started bridging AT => any: Allow opt-in while hidden from logged-out users Nov 24, 2024
@snarfed
Copy link
Owner

snarfed commented Nov 24, 2024

That's an interesting one. I think the behaviour is intentional, since hiding an account from logged-out users shouldn't just delete the fediverse bridge account (as that would sever all connections on ActivityPub).

Yeah it's an interesting question. Once we detect the setting change, should we keep bridging? Or keep the bridged profile but pause bridging? Or delete the bridged profile entirely?

I think that question belongs in #1293 or nearby more than here. For this question, as you saw in #1549 (comment) , I'm likely to keep opt in/out as simple and black-and-white as possible, and just not allow bridging when "hide from logged-out users" is on. We can consider leaving this open to track the request though.

@snarfed
Copy link
Owner

snarfed commented Dec 4, 2024

#1293 now includes detecting when a Bluesky user changes their "hide from logged-out users" setting. Other than that, as discussed, I don't really plan to allow Bluesky users with that setting enabled to use the bridge. Sorry for the bad news.

@snarfed snarfed closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features and feature requests that are specific to Bridgy Fed, not fully described by the protocols.
Projects
None yet
Development

No branches or pull requests

3 participants