Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outbound AP Follows from tmichellemoore.com failing inbox delivery with "Unexpected object type for key" #370

Closed
snarfed opened this issue Jan 15, 2023 · 9 comments

Comments

@snarfed
Copy link
Owner

snarfed commented Jan 15, 2023

We started seeing outbound AP inbox deliveries of Follow activities for tmichellemoore.com fail with HTTP 401 "Unexpected object type for key https://fed.brid.gy/tmichellemoore.com" recently. First instance in logs is 1/4 22:03 PT, seen from a number of instances including mstdn.social, toot.community, and masto.ai. Only for that domain, only Follows. Oddly specific. Apologies @tmichellemoore!

@snarfed
Copy link
Owner Author

snarfed commented Jan 15, 2023

This accounts for most of @tmichellemoore's follows since 1/4, but not all. eg here's one to mastodon.social on 1/5 that succeeded.

All of the affected instances I looked at are on 4.0.2, but mastodon.social is too. I don't know for sure that it was on 1/5, but I expect so, since it generally upgrades quickly, and 4.0.2 was released in Nov.

@snarfed
Copy link
Owner Author

snarfed commented Jan 15, 2023

@snarfed
Copy link
Owner Author

snarfed commented Jan 15, 2023

Well that's odd, https://fed.brid.gy/tmichellemoore.com has neither type: Person nor publicKey. That's broken.

{
  "@context": "https://www.w3.org/ns/activitystreams",
  "attachment": [
    {
      "type": "Image",
      "url": "https://tmichellemoore.com/wp-content/uploads/2022/11/DSC04496.jpg"
    }
  ],
  "attributedTo": [
    {
      "id": "https://fed.brid.gy/tmichellemoore.com",
      "name": "T Michelle Moore",
      "preferredUsername": "tmichellemoore.com",
      "type": "Person",
      "url": "https://fed.brid.gy/r/https://tmichellemoore.com/"
    }
  ],
  "endpoints": {
    "sharedInbox": "https://fed.brid.gy/inbox"
  },
  "followers": "https://fed.brid.gy/tmichellemoore.com/followers",
  "following": "https://fed.brid.gy/tmichellemoore.com/following",
  "id": "https://fed.brid.gy/tmichellemoore.com",
  "image": {
    "type": "Image",
    "url": "https://tmichellemoore.com/wp-content/uploads/2022/11/DSC04496.jpg"
  },
  "inbox": "https://fed.brid.gy/tmichellemoore.com/inbox",
  "outbox": "https://fed.brid.gy/tmichellemoore.com/outbox",
  "preferredUsername": "tmichellemoore.com",
  "summary": "Project Manager | Photographer",
  "to": [
    "https://www.w3.org/ns/activitystreams#Public"
  ],
  "url": "https://fed.brid.gy/r/https://tmichellemoore.com/"
}

@snarfed
Copy link
Owner Author

snarfed commented Jan 15, 2023

Got it. tmichellemoore.com's h-card has no name, so mf2util.post_type_discovery returns org, which we don't know how to handle, instead of person.

@tmichellemoore
Copy link

Hi @snarfed, Can you translate some of your items above? And regarding the h-cars...Mine seems to work in different ways, but on the one that I placed on my home page footer and place on my blog posts, my name is in there. I can check to make sure but I removed the org a few weeks ago. I am not sure if the IndieWeb plug-in's h-card does anything for my site since I don't use the classic editor, but it has added fields to my User. I also have a mystery of why the h-card in the footer doesn't work on the blog posts. (I know this is a different plug-in's topic.)

@snarfed
Copy link
Owner Author

snarfed commented Jan 15, 2023

@tmichellemoore sorry! Everything here is just my own working notes, not anything you need to worry about. This is a BF bug, I should have it fixed soon.

@tmichellemoore
Copy link

@snarfed Got it!! Thank you!

@snarfed
Copy link
Owner Author

snarfed commented Jan 15, 2023

Fixed! Mainly by kylewm/mf2util#22 and snarfed/granary@3688c3d

@snarfed snarfed closed this as completed Jan 15, 2023
@tmichellemoore
Copy link

@snarfed I have a confession. I was just experimenting with my h-card and I had an organization. lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants