Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star GitHub repos on favorite as well as like #1345

Closed
mjgardner opened this issue Nov 11, 2022 · 5 comments
Closed

Star GitHub repos on favorite as well as like #1345

mjgardner opened this issue Nov 11, 2022 · 5 comments

Comments

@mjgardner
Copy link

I am using @dshanske's Post Kinds WordPress plugin, and I noticed that Bridgy only starred a GitHub repo that used the plugin's "Like" rather than "Favorite." This was confusing at first because the plugin uses a star icon to indicate "Favorite."

@snarfed
Copy link
Owner

snarfed commented Nov 11, 2022

Sure! Sounds like this change would need to happen in that WordPress plugin though, not in Bridgy, right? cc @dshanske

@mjgardner
Copy link
Author

I’m not so sure. The plug-​in uses a dif­fer­ent prop­er­ty for each (like-​of vs. favorite-​of) and there’s some argu­ment that they mean dif­fer­ent things to users and are treat­ed dif­fer­ent­ly on dif­fer­ent sys­tems, though I don’t think any sys­tem cur­rent­ly uses both. So a POSSE gate­way like Bridgy should con­sol­i­date both to a sin­gle prop­er­ty for sys­tems that do that, but pre­serve the abil­i­ty to keep them sep­a­rate should a dif­fer­ent (or new­er ver­sion) receiv­er dis­tin­guish between the two.

In any case I think the plug-​in should pre­serve the exist­ing prop­er­ties authors have already added to posts rather than lose infor­ma­tion by con­sol­i­dat­ing their mean­ing at the source.

Related

(Originally published at: https://phoenixtrap.com/2022/11/11/not_sure_bridgy_github_star/)

@snarfed
Copy link
Owner

snarfed commented Nov 11, 2022

Ah, sure! Understood, will do.

Are you posting u-favorite-of posts then? Looks like https://phoenixtrap.com/2022/11/11/bridgy-github/ is a u-like-of, I'm guessing you changed it to make Bridgy understand it. If/when you have a u-favorite-of post, could you add it and yourself to https://indieweb.org/favorite#IndieWeb_Examples ? Favorite posts are still pretty rare on the IndieWeb, and u-favorite-of isn't yet official mf2, unlike u-like-of. I don't even see an issue for it yet. cc @dshanske if Post Kinds is publishing u-favorite-of.

@snarfed
Copy link
Owner

snarfed commented Nov 11, 2022

@snarfed
Copy link
Owner

snarfed commented Nov 11, 2022

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants