Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake comment/like permalinks by adding fragment (e.g. #USERID) #215

Closed
10 tasks done
snarfed opened this issue Jul 3, 2014 · 5 comments
Closed
10 tasks done

fake comment/like permalinks by adding fragment (e.g. #USERID) #215

snarfed opened this issue Jul 3, 2014 · 5 comments
Labels

Comments

@snarfed
Copy link
Owner

snarfed commented Jul 3, 2014

we already do this for FB event attendee RSVPs, might as well do it for G+ comments too.

cc @kartikprabhu

status:

  • N/A: Facebook comments
  • Facebook likes
  • Facebook RSVPs
  • Twitter favorites
  • N/A: Twitter replies
  • Google+ comments
  • Google+ +1s
  • Google+ shares
  • Instagram comments
  • Instagram likes
  • Flickr comments
  • Flickr likes
@snarfed
Copy link
Owner Author

snarfed commented Jul 3, 2014

@snarfed
Copy link
Owner Author

snarfed commented Jul 7, 2014

also see snarfed/granary@4287869

@snarfed
Copy link
Owner Author

snarfed commented Jul 8, 2014

had to revert G+ in snarfed/granary@b6bfed0. 😦

@snarfed snarfed changed the title fake G+ comment permalinks (and others?) by adding #USERID fragment fake comment/like permalinks by adding fragment (e.g. #USERID) Jan 4, 2016
@snarfed
Copy link
Owner Author

snarfed commented Jan 4, 2016

reopening since we should do this for more responses, e.g. FB likes. inspired by IRC. cc @tantek @dissolve @aaronpk

one motivation is that some webmention receivers may de-dupe on url instead of uid, so we want to try to make each response's url unique if possible. webmention.io is an example of this; its API omits uid when serving webmentions to consumers, so consumers often default to de-duping on url. :/

(omitting u-url entirely is another option, but not a great one, since then webmention receivers would default to linking to bridgy's own mf2 pages, which we don't really want users to ever click through to and see. pointing them to the silo post is pretty much always the better experience.)

@snarfed snarfed reopened this Jan 4, 2016
@dissolve
Copy link

dissolve commented Jan 4, 2016

agreed that omitting u-url is not a good solution. +1 to urls being unique via fragment

snarfed added a commit to snarfed/granary that referenced this issue Jan 5, 2016
snarfed added a commit to snarfed/granary that referenced this issue Jan 5, 2016
snarfed added a commit to snarfed/granary that referenced this issue Jan 5, 2016
…urls to make them unique

for snarfed/bridgy#215

we originally added these in 7d7ec40 and 4287869, then removed them in b6bfed0 because fragments broke G+'s JS-based navigation, then added them back for just comments in #444 because those worked ok. since then G+ has redesigned and now evidently doesn't mind fragments. they still get stripped after page load, but they at least don't break it.
@snarfed snarfed closed this as completed Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants