New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backfeed silo mentions from other people #523

Closed
snarfed opened this Issue Oct 23, 2015 · 8 comments

Comments

Projects
None yet
3 participants
@snarfed
Copy link
Owner

snarfed commented Oct 23, 2015

e.g. if someone else tweets 'hey @username foo bar!', we'd send it as a webmention to your web site's front page. same with user mentions/tags on FB, G+, and IG.

similar to #488. inspired by #456 (comment). (thanks @singpolyma!)

@snarfed snarfed added the listen label Oct 23, 2015

@snarfed snarfed added the SWAT0 label Nov 5, 2015

@snarfed

This comment has been minimized.

Copy link
Owner Author

snarfed commented Nov 10, 2015

current silo support:

@snarfed

This comment has been minimized.

Copy link
Owner Author

snarfed commented Nov 21, 2015

one wrinkle here if that twitter @-replies usually mention the tweet's author, but they probably shouldn't get backfed to the front page as mentions.

however, if someone mentions you in a reply to someone else, that maybe should get backfed.

here's a straw man: if a mention isn't a reply, backfeed it. if it is, but it's not a reply to you, and if the tweet it's replying to doesn't mention you, backfeed it.

(other silos don't start comments with mentions by default, so they don't have this problem.)

@singpolyma

This comment has been minimized.

Copy link
Contributor

singpolyma commented Nov 21, 2015

I'm ok with not doing the backfeed a second time for posts that are a direct reply to you. But I'd also be ok with doing it, since it still mentions you. Either way.

@snarfed snarfed self-assigned this Nov 21, 2015

snarfed added a commit to snarfed/granary that referenced this issue Nov 21, 2015

@snarfed

This comment has been minimized.

Copy link
Owner Author

snarfed commented Nov 21, 2015

sounds good!

i'm also inclined to suppress mention backfeed when we find an original post link to one of your sites, e.g. tweets like these, so that we don't double backfeed those either.

snarfed added a commit to snarfed/granary that referenced this issue Nov 22, 2015

snarfed added a commit to snarfed/granary that referenced this issue Nov 22, 2015

snarfed added a commit that referenced this issue Nov 22, 2015

snarfed added a commit that referenced this issue Nov 22, 2015

snarfed added a commit to snarfed/granary that referenced this issue Nov 23, 2015

snarfed added a commit that referenced this issue Nov 23, 2015

testutil refactoring move set_activities() etc from FakeSource to Fak…
…eGrSource

so that tests run the real Source.get_activities(), now that it actually does something.

for #523

snarfed added a commit that referenced this issue Nov 23, 2015

@snarfed

This comment has been minimized.

Copy link
Owner Author

snarfed commented Nov 23, 2015

turning this on now. hold onto your britches...

snarfed added a commit that referenced this issue Nov 23, 2015

snarfed added a commit to snarfed/granary that referenced this issue Nov 23, 2015

@snarfed

This comment has been minimized.

Copy link
Owner Author

snarfed commented Nov 23, 2015

first confirmed kill!
https://brid.gy/twitter/leitmedium#responses
https://twitter.com/nordhessenmami/status/668539086567809025

(their site doesn't accept front page webmentions, but that's fine.)

@snarfed snarfed closed this Nov 23, 2015

snarfed added a commit to snarfed/granary that referenced this issue Nov 23, 2015

@snarfed

This comment has been minimized.

Copy link
Owner Author

snarfed commented Nov 23, 2015

example of one that did go through:

https://twitter.com/lucavgobbi/status/668762681000796160
http://www.kevinmarks.com/

(i love how @kevinmarks's use of webmention.herokuapp.com on his front page is kind of a light stress test. :P)

@dissolve

This comment has been minimized.

Copy link

dissolve commented Nov 23, 2015

getting these now but they don't actually refer to my URL, for example
it sent me a webmention of https://brid-gy.appspot.com/post/facebook/14305603/837135243002270 pointing to https://ben.thatmustbe.me/
but my homepage URL is missing from the generated page

snarfed added a commit that referenced this issue Nov 25, 2015

snarfed added a commit to snarfed/granary that referenced this issue Dec 28, 2015

microformats2.object_to_json: don't short circuit at some tag types
this was breaking rendering user mention URLs (snarfed/bridgy#523) for posts with non-hashtag non-person tags, e.g. links. oops!

snarfed added a commit that referenced this issue Jan 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment