New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate @reply prepended to tweet #703

Closed
singpolyma opened this Issue Oct 18, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@snarfed

This comment has been minimized.

Show comment
Hide comment
@snarfed

snarfed Oct 18, 2016

Owner

oops! thanks for the report this is probably due to recent changes we made for twitter's new "extended tweet" char counting changes, snarfed/granary#89:
https://brid.gy/about#extended-tweets
https://dev.twitter.com/overview/api/upcoming-changes-to-tweets

...yup, that tweet's API object shows that twitter itself added the first @-mention because bridgy uses the new auto_populate_reply_metadata=true. the display_text_range puts it outside of the text that should be displayed.

{
  "id_str": "788347659916484608",
  "full_text": "@jlamothe1980 @jlamothe1980 you want lift from https://t.co/i70VL80zbH (https://t.co/ahUg4B5gS7)",
  "display_text_range": [
    14,
    96
  ],
  "..."

i think the conclusion is that twitter's UI(s) themselves haven't quite caught up to their own changes yet. i expect they will soon. in the meantime, i'd suggest that you now omit the in-reply-to @-mention in your replies. (sorry, i know bridgy/twitter used to require it!)

i'll figure out a way to PSA this to bridgy publish users.

Owner

snarfed commented Oct 18, 2016

oops! thanks for the report this is probably due to recent changes we made for twitter's new "extended tweet" char counting changes, snarfed/granary#89:
https://brid.gy/about#extended-tweets
https://dev.twitter.com/overview/api/upcoming-changes-to-tweets

...yup, that tweet's API object shows that twitter itself added the first @-mention because bridgy uses the new auto_populate_reply_metadata=true. the display_text_range puts it outside of the text that should be displayed.

{
  "id_str": "788347659916484608",
  "full_text": "@jlamothe1980 @jlamothe1980 you want lift from https://t.co/i70VL80zbH (https://t.co/ahUg4B5gS7)",
  "display_text_range": [
    14,
    96
  ],
  "..."

i think the conclusion is that twitter's UI(s) themselves haven't quite caught up to their own changes yet. i expect they will soon. in the meantime, i'd suggest that you now omit the in-reply-to @-mention in your replies. (sorry, i know bridgy/twitter used to require it!)

i'll figure out a way to PSA this to bridgy publish users.

@singpolyma

This comment has been minimized.

Show comment
Hide comment
@singpolyma

singpolyma Oct 18, 2016

Contributor

could bridgy remove if present before sending to twitter?

Contributor

singpolyma commented Oct 18, 2016

could bridgy remove if present before sending to twitter?

@snarfed

This comment has been minimized.

Show comment
Hide comment
@snarfed

snarfed Oct 18, 2016

Owner

definitely a good idea. doing that the Right Way would mean i'd need to fetch the in-reply-to tweet, but i could probably hack it by just parsing the username out of the URL, which should work almost all the time. i'll do that.

Owner

snarfed commented Oct 18, 2016

definitely a good idea. doing that the Right Way would mean i'd need to fetch the in-reply-to tweet, but i could probably hack it by just parsing the username out of the URL, which should work almost all the time. i'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment