Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github publish: handle repos with >100 labels #803

Open
snarfed opened this Issue Mar 22, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@snarfed
Copy link
Owner

snarfed commented Mar 22, 2018

@tantek recently published http://tantek.com/2018/074/b2/css-color-3-needs-link-editor-draft to w3c/csswg-drafts#2445 (log), which included the css-color-3 and Needs Edits labels, but only css-color-3 actually got attached to the github issue.

this is because i use github's GraphQL API to fetch the repo's labels, and it limits results to 100 items, and the csswg-drafts repo has more than 100 labels. (!)

i guess i should detect this and fetch more pages of labels when necessary. whee!

@snarfed snarfed added the publish label Mar 22, 2018

@tantek

This comment has been minimized.

Copy link
Contributor

tantek commented Jul 13, 2018

Here is another more recent example:

<http://tantek.com/2018/190/b1/scrollbar-gutter-move-to-css-scrollbars>

New issue, with two labels: css-overflow-4, css-scrollbars-1

Only the first label was added to the Bridgy Publish POSSE copy:

<w3c/csswg-drafts#2899>

Is this the same problem? I thought perhaps with the switch from GraphQL to the GitHub v3 API a few weeks (months?) ago, this might have been fixed at the same time.

Whatever the cause is, some labels are still not getting through via publish.

(Originally published at: http://tantek.com/2018/193/t1/)

@snarfed

This comment has been minimized.

Copy link
Owner Author

snarfed commented Jul 13, 2018

heh, sorry for the trouble. yup, same missing feature, paging through multiple pages of labels past the first 100 for a repo. the recent switch from graphql to rest v3 api was just a couple calls, not the whole codebase, and the rest v3 api has the same max 100 item per page limit: https://developer.github.com/v3/guides/traversing-with-pagination/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.