Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridgy Publish to GitHub should preserve markup in plaintext as such #810

Closed
tantek opened this issue Apr 18, 2018 · 0 comments
Closed

Bridgy Publish to GitHub should preserve markup in plaintext as such #810

tantek opened this issue Apr 18, 2018 · 0 comments
Labels

Comments

@tantek
Copy link
Contributor

@tantek tantek commented Apr 18, 2018

When using Bridgy Publish to POSSE a comment (or issue) to GitHub, it should preserve any visible plaintext markup from the source as visible plaintext markup on GitHub.

Example: http://tantek.com/2018/107/t3/ has a [data] element example, while the POSSE copy seems to have lost the <data> (but it's still in the Markdown source if I click edit)

Note that the preceding paragraph also has visible plaintext markup - "data" tag, escaped in the original: tantek.com/2018/107/b1 thus it should also be escaped and displayed in the copy of this issue on GitHub.

HTML2text should (maybe?) handle this, or if not, Bridgy Publish could escape any visible '<' (less than), '>' (greater than), and '&' (ampersand) characters from the source before publishing to GitHub.

Label(s): publish

(Originally published at: http://tantek.com/2018/107/b1/)

Update: Now that this is fixed, I edited to escape data tag in this issue description, and also edited microformats/microformats2-parsing#10 (comment) to escape its data element

@snarfed snarfed closed this in 2a231ec Apr 20, 2018
snarfed added a commit to snarfed/granary that referenced this issue Dec 26, 2019
…o `s

... so that GitHub renders HTML entities like &gt; inside them instead of leaving them escaped. background: https://chat.indieweb.org/dev/2019-12-24#t1577174464779200

the html2text people have gone back and forth on how to handle this: Alir3z4/html2text#57, Alir3z4/html2text#109, etc. original bridgy publish github escaping was added in snarfed/bridgy#810.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants