Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
404s from github API for publish #824
@tantek got a 404 from the github API just now when trying to publish a
we started to suspect a github API bug, but then i found that API 404s can evidently be caused by:
if it's one of those, we should detect this and return a better error message.
tantek tried re-authing github on bridgy, but no luck. he also noted that if the org was blocking API writes, https://developer.github.com/changes/2015-01-19-an-integrators-guide-to-organization-application-policies/ says the API call would return 403, not 404.
new clue! looks like it is org permissions after all. @tantek saw similar failures attempting to comment on another org's repo. we got this useful error message back from the create comment graphql API call:
so, we should probably catch and surface this, and maybe say something similar on 404s.
(tangentially, interesting that the graphql API gave us a human readable error message, while the REST API gave us an opaque 404...but it was also a comment vs a reaction, so who knows.)