New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snarfed/bridgy MIDDLE DOT in post url causes bridgy to fail to match #834

Closed
dougbeal opened this Issue Jul 17, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@dougbeal

dougbeal commented Jul 17, 2018

Picked up a

U+00B7 : MIDDLE DOT {midpoint (in typography); Georgian comma; Greek middle dot (ano teleia)}

from using PressThis Reply bookmarklet in wordpress post title.

https://brid.gy/log?start_time=1531789624&key=aglzfmJyaWQtZ3lyWQsSCFJlc3BvbnNlIkt0YWc6Z2l0aHViLmNvbSwyMDEzOnNuYXJmZWQ6YnJpZGd5LWZlZDpNREV5T2tsemMzVmxRMjl0YldWdWREUXdOVFF3TlRjME5BPT0M
2018-07-17 01:07:04.077080 I Giving up this target. {'body_json': {u'message': u'Cannot find target link', u'code': u'...', u'data': {u'status': 400, u'data': {u'comment_date': u'2018-07-16 18:07:02', u'comment_approved': 0, u'target': u'https://dougbeal.com/2018/07/16/snarfed-bridgy-fed-bridgy-error-on-like-\xb7-issue-28-\xb7-snarfed-bridgy-fed/', u'comment_type': u'webmention', u'comment_date_gmt': u'2018-07-17 01:07:02', u'comment_meta': {u'webmention_target_url': u'https://dougbeal.com/2018/07/16/snarfed-bridgy-fed-bridgy-error-on-like-\xb7-issue-28-\xb7-snarfed-bridgy-fed/', u'webmention_created_at': u'2018-07-17 01:07:02', u'webmention_source_url': u'https://brid-gy.appspot.com/comment/github/dougbeal/snarfed:bridgy-fed:28/snarfed:bridgy-fed:MDEyOklzc3VlQ29tbWVudDQwNTQwNTc0NA=='}, u'comment_author_IP': u'107.178.194.9', u'source': u'https://brid-gy.appspot.com/comment/github/dougbeal/snarfed:bridgy-fed:28/snarfed:bridgy-fed:MDEyOklzc3VlQ29tbWVudDQwNTQwNTc0NA==', u'comment_agent': u'Bridgy (https://brid.gy/about) AppEngine-Google; (+http://code.google.com/appengine; appid: s~brid-gy)', u'comment_author_url': u'https://brid-gy.appspot.com/comment/github/dougbeal/snarfed:bridgy-fed:28/snarfed:bridgy-fed:MDEyOklzc3VlQ29tbWVudDQwNTQwNTc0NA==', u'comment_post_ID': 1881, u'comment_parent': u'', u'comment_author_email': u''}}}, 'code': '...', 'request': u'POST https://dougbeal.com/wp-json/webmention/1.0/endpoint (with source=https://brid-gy.appspot.com/comment/github/dougbeal/snarfed:bridgy-fed:28/snarfed:bridgy-fed:MDEyOklzc3VlQ29tbWVudDQwNTQwNTc0NA==, target=https://dougbeal.com/2018/07/16/snarfed-bridgy-fed-bridgy-error-on-like-%c2%b7-issue-28-%c2%b7-snarfed-bridgy-fed/)', 'http_status': 400}

(Originally published at: https://crw.moe/b/XS)

@dougbeal

This comment has been minimized.

dougbeal commented Jul 17, 2018

nows it looking like an encoding issue -
on-like-\xb7-issue-28 vs on-like-%c2%b7-issue-28

@snarfed

This comment has been minimized.

Owner

snarfed commented Jul 17, 2018

whee, Unicode!

that 400 error is from your web server (looks like WordPress?). the url with the \xes is a logging artifact, purely internal to bridgy. i think it's correctly sending the %-encoded url as the webmention target (search that error json for "target.")

@snarfed

This comment has been minimized.

Owner

snarfed commented Jul 17, 2018

similar: #625

@snarfed

This comment has been minimized.

Owner

snarfed commented Jul 20, 2018

@dougbeal friendly ping. is the WordPress webmention plugin maybe not handling Unicode in URLs correctly?

@dougbeal

This comment has been minimized.

dougbeal commented Jul 20, 2018

@snarfed

This comment has been minimized.

Owner

snarfed commented Jul 23, 2018

tentatively closing. (bridgy has successfully sent webmentions to many other urls with unicode chars before in the past.) @dougbeal feel free to reopen if you do determine this is still a bridgy bug somewhere!

@snarfed snarfed closed this Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment