New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish: support pictures #85

Closed
snarfed opened this Issue Mar 10, 2014 · 13 comments

Comments

Projects
None yet
5 participants
@snarfed
Owner

snarfed commented Mar 10, 2014

needs new API usage for both FB and twitter, but should be pretty straightforward.

cc @kartikprabhu

@snarfed snarfed added now and removed now labels Mar 10, 2014

@snarfed

This comment has been minimized.

Owner

snarfed commented Apr 3, 2014

one big question here is whether there's mf2 markup to identify pictures that are the primary content of a post, as opposed to just decoration. if not, I can start with just the first picture(s) inside the e-content.

@kartikprabhu

This comment has been minimized.

kartikprabhu commented Apr 3, 2014

@snarfed how about using the u-photo of the h-entry and as a fallback use the first image. FB uses the <meta name="thumbnail" content="thumbnail-url"> which I have kept in my articles because the square thumbnails don't fit anywhere in the actual post. ref: http://kartikprabhu.com/article/indieweb-love-blog

@snarfed

This comment has been minimized.

Owner

snarfed commented Apr 3, 2014

sgtm!

@dshanske

This comment has been minimized.

dshanske commented Jun 3, 2014

I'm marking up h-entries as h-as-image for posts which are primarily an image post. I stole it from others doing it, along with h-as-page, h-as-article, h-as-bookmark

http://microformats.org/wiki/activitystreams

It is an experimental markup, I believe. There is also a proposal for a u-photo in an h-entry noted as an option for marking up the primary image.

@snarfed

This comment has been minimized.

Owner

snarfed commented Jul 9, 2014

for anyone interested in tackling this, the changes would (probably) be isolated to just twitter._create() and facebook._create() in activitystreams-unofficial. it'd be fine to do just one or the other, too.

cc @notenoughneon

@snarfed

This comment has been minimized.

Owner

snarfed commented Jul 15, 2014

lots of good discussion on irc today on how to determine whether a post is a "photo" post, and if so, which photo(s). they've started wikifying it on Photos#Discussion.

@kylewm

This comment has been minimized.

Collaborator

kylewm commented Jul 16, 2014

I'm pretty well convinced that a note with a photo should be syndicated like a photo, full stop.

In the discussion today, I could only come up with one counter-example https://kylewm.com/note/2014/05/05/1 and even that is kind of a toss up.

@snarfed snarfed added now and removed later labels Jul 19, 2014

@snarfed

This comment has been minimized.

Owner

snarfed commented Aug 5, 2014

done for twitter! by @notenoughneon in snarfed/granary#16. it just uses the first u-photo.

snarfed added a commit to snarfed/granary that referenced this issue Aug 13, 2014

@snarfed snarfed added later and removed now labels Aug 13, 2014

@snarfed

This comment has been minimized.

Owner

snarfed commented Aug 21, 2014

moving back to now since i'd like to do this for facebook too.

@snarfed snarfed added now and removed later labels Aug 21, 2014

@notenoughneon

This comment has been minimized.

notenoughneon commented Aug 22, 2014

I've started working on facebook support.

@snarfed

This comment has been minimized.

Owner

snarfed commented Aug 22, 2014

awesome, glad to hear it!

@kylewm

This comment has been minimized.

Collaborator

kylewm commented Aug 22, 2014

@notenoughneon exciting!

there's a little bit of code in redwind for posting photos to facebook, feel free to reference or ignore :)

https://github.com/kylewm/redwind/blob/fb012f5741cdacacba2bb14b6bf7adc8794c2ce8/redwind/plugins/facebook.py#L174

@snarfed

This comment has been minimized.

Owner

snarfed commented Aug 23, 2014

thanks again, @notenoughneon! done in snarfed/granary#20.

@snarfed snarfed closed this Aug 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment