-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invisible u-mention links leave large gaps on WordPress #903
Comments
To comment... I don't see this in the Bridgy documentation... |
sorry for the trouble, @edent! and nice sleuthing. those more importantly, i definitely can change bridgy's markup to avoid the line breaks in your wordpress, but i'm reluctant, since whitespace and line breaks in HTML don't (shouldn't) affect rendering, and if i start customizing for one web server, i'll inevitably hear from another one that needs a different customization that conflicts. do you maybe have a plugin that interprets HTML whitespace in comments as meaningful? maybe change that plugin? @dshanske, any ideas? |
I think the issue is that WordPress sees the linebreaks in the comments and renders them as This is in line with https://indieweb.org/note#Indieweb_whitespace_thinking I'm using the semantic-linkback plugin, which enters them into the WordPress database with You are right not to make a major change like this - especially as it might affect others. But given that there is not designed to be anything visible to the user, I don't see what semantic use the |
this is probably the problem. cc @dshanske. Bridgy obviously isn't posting a WP comment itself, it's just publishing HTML, in which pure whitespace is not significant. so it sounds like the Semantic Linkbacks plugin shouldn't be converting line breaks in HTML to line breaks in WP comments, since they become meaningful there.
you're right! there isn't any. i'd like @dshanske to look at the SL plugin here first, and ideally fix it there, since this is bigger than just a Bridgy issue. if that's not possible for some reason, i'm happy to change Bridgy; i just can't guarantee that that change will survive permanently in the future. |
(btw, i'm all too familiar with https://indieweb.org/note#Indieweb_whitespace_thinking , i've spent a fair amount of time on at least two different implementations across granary, bridgy, and bridgy fed. a key point here is that bridgy's HTML has neither the |
tentatively closing, since we seem to all agree on the conclusion that this whitespace in HTML isn't meaningful and shouldn't affect the way receivers render mentions. feel free to reopen if anything changes! |
(This might be a bit obscure - and please forgive me if I've misunderstood something about the way Webmention works....)
Bridgy has successfully picked up a Twitter reply to my blog post (yay!)
https://brid-gy.appspot.com/comment/twitter/edent/1209420474964496385/1209445040814272513
At the bottom are some links with no content:
This causes a large gap at the bottom of the rendered comment:
What is the purpose of these links? Assuming they shouldn't be removed, would it be possible to change snarfed/granary@f8b10c6 (Fix for #163) so that they're joined with a space rather than a newline?
(Originally raised as pfefferle/wordpress-semantic-linkbacks#234)
The text was updated successfully, but these errors were encountered: