Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Meetup.com #906

Draft
wants to merge 10 commits into
base: master
from
Draft

WIP: Meetup.com #906

wants to merge 10 commits into from

Conversation

@jamietanna
Copy link

jamietanna commented Dec 30, 2019

Testing needed, both via unit test, and checking in the UI, but thought I'd start with this to see if there's anything obvious that needs to change.

Requires snarfed/granary#179 to be merged, first

jamietanna added 5 commits Dec 30, 2019
WIP
@@ -15,6 +15,8 @@
{{ sources['flickr'].button_html('listen')|safe }}
{{ sources['github'].button_html('listen')|safe }}
{{ sources['mastodon'].button_html('listen')|safe }}

This comment has been minimized.

Copy link
@jamietanna

jamietanna Dec 31, 2019

Author

How can I add one of these for /meetup/publish/start?

This comment has been minimized.

Copy link
@snarfed

snarfed Dec 31, 2019

Owner

just blindly copying and modifying one of these lines should work, right?

Copy link
Owner

snarfed left a comment

cool! looks pretty good. surprisingly small, but i won't argue 😎 does it work?

handlers.py Outdated
@@ -35,7 +35,7 @@
import util

# Import source class files so their metaclasses are initialized.
import blogger, flickr, github, instagram, mastodon, medium, tumblr, twitter, wordpress_rest
import blogger, flickr, github, instagram, mastodon, medium, meetup, tumblr, twitter, wordpress_rest

This comment has been minimized.

Copy link
@snarfed

snarfed Dec 31, 2019

Owner

this is just for backfeed, feel free to omit it for Meetup until if/when we implement that.

meetup.py Outdated

@classmethod
def button_html(cls, feature, **kwargs):
return super(cls, cls).button_html(feature, form_method='get', **kwargs)

This comment has been minimized.

Copy link
@snarfed

snarfed Dec 31, 2019

Owner

is this override necessary? if so, do you want to assert or manually set feature to just publish?

@@ -15,6 +15,8 @@
{{ sources['flickr'].button_html('listen')|safe }}
{{ sources['github'].button_html('listen')|safe }}
{{ sources['mastodon'].button_html('listen')|safe }}
{{ sources['meetup'].button_html('listen')|safe }}

This comment has been minimized.

Copy link
@snarfed

snarfed Dec 31, 2019

Owner

delete this one, we don't support listen (aka backfed) yet

@jamietanna

This comment has been minimized.

Copy link
Author

jamietanna commented Jan 8, 2020

i've been able to successfully OAuth, which takes me back to http://localhost:8080/edit-websites?source_key=..., with the details for my user, but then going to my user page (http://localhost:8080/meetup/189380737) fails with a 404.

When printing what's there for that ID:

>>> print(Meetup.get_by_id('189380737'))
Meetup(key=Key('Meetup', '189380737'), auth_entity=Key('MeetupAuth', '189380737'), blocked_ids=None, created=datetime.datetime(2020, 1, 7, 22, 27, 4, 980076), domain_urls=[], domains=[], features=[], last_activities_cache_json=None, last_activities_etag=None, last_activity_id=None, last_feed_syndication_url=None, last_hfeed_refetch=datetime.datetime(1970, 1, 1, 0, 0), last_poll_attempt=datetime.datetime(1970, 1, 1, 0, 0), last_polled=datetime.datetime(1970, 1, 1, 0, 0), last_public_post=None, last_syndication_url=None, last_webmention_sent=None, name='Jamie Tanna', picture='https://secure.meetupstatic.com/photos/member/6/8/7/5/member_288326741.jpeg', poll_status='ok', rate_limited=False, recent_private_posts=0, seen_responses_cache_json=None, status='enabled', superfeedr_secret=None, url='https://www.meetup.com/members/189380737/', webmention_endpoint=None)

However, it doesn't display in the datastore viewer and http://localhost:8000/datastore-stats shows 0 entries in the datastore.

That works, so not sure what's going wrong.

@snarfed

This comment has been minimized.

Copy link
Owner

snarfed commented Jan 8, 2020

man, that is so weird. you're definitely looking at the right things.

maybe you have another instance of the datastore emulator running? not sure how that would cause this symptom, but you can kill it just in case with something like pkill -KILL -f datastore.

or maybe the datastore emulator app id doesn't match from request to request? not sure how that would happen though.

it's particularly odd that the /edit-websites request loads it ok, but the user page request doesn't, and that http://localhost:8000/ doesn't show it. so odd.

@jamietanna

This comment has been minimized.

Copy link
Author

jamietanna commented Jan 8, 2020

I'll certainly give those a go. Would you be able to see if you can reproduce it yourself, locally? I can send over the client_id and client_secret (as you'll need them anyway)

@jamietanna

This comment has been minimized.

Copy link
Author

jamietanna commented Jan 8, 2020

Ah I may have found the issue https://github.com/snarfed/bridgy/blob/master/app.py#L210-L212 expects there to be features on it, but I haven't got any set. I guess I need to inject in a feature and it'll work?

@jamietanna

This comment has been minimized.

Copy link
Author

jamietanna commented Jan 8, 2020

Hmm, how would I go about doing that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.