persistent connections - use a different persistent_id per DSN #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using persistent connections with different clients using the same redis server but different databases, the call to 'select' will only be issued during the client's construction, and it will happen on the same persistent connection. You'll end up working on the last opened client's database.
To fix this, I propose to use the persistent_id that can be given to pconnect (https://github.com/nicolasff/phpredis#pconnect-popen) and to tie the persistent connection to the full dsn (using an sha1 of the DSN).