Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename assets #31

Closed
ashwinvis opened this issue Apr 14, 2021 · 5 comments · Fixed by #172
Closed

Rename assets #31

ashwinvis opened this issue Apr 14, 2021 · 5 comments · Fixed by #172
Assignees
Milestone

Comments

@ashwinvis
Copy link
Member

Find a better name for subpackage assets and function get_asset.

@ashwinvis ashwinvis added this to To do in ExABL Sep 21, 2021
@ashwinvis ashwinvis added this to To do in snek5000 project Sep 24, 2021
@ashwinvis ashwinvis removed this from To do in ExABL Feb 11, 2022
@ashwinvis ashwinvis added this to the 0.8.0 milestone Jun 18, 2022
@paugier
Copy link
Contributor

paugier commented Oct 27, 2022

Could we use just "resources" and get_resource (as importlib.resources)? At least for me the name "resource" make more sense than asset. But actually "asset" would also be fine.

@ashwinvis
Copy link
Member Author

The problem with simple resources module / get_resource function name is that it gets confusing with

  • the importlib.resources package where resources means all the files in any given package
  • and with snek5000.output.base.Output._get_resources method in
    def _get_resources(self, package=None):

We need something more unique. I suggest one of the following and we can vote with 👍

@ashwinvis
Copy link
Member Author

snek_resources / get_snek_resource

@ashwinvis
Copy link
Member Author

sim_resources / get_sim_resource

@ashwinvis
Copy link
Member Author

@paugier and @akhoubani which do you like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants