New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong commands, support pass through arguments. #5

Merged
merged 1 commit into from Feb 9, 2019

Conversation

2 participants
@wi1dcard
Copy link
Contributor

wi1dcard commented Feb 5, 2019

There's a couple of things:

  1. docker-compose down will Stop and remove containers, networks, images, and volumes. A better choice for stopping the docker-compose started service may be docker-compose stop.
  2. To restart service, just use docker-compose restart.
  3. $@ in bash stores all arguments passed through the script. For example, people usually use -d with docker-compose up to run containers in the background. So add $@ will be useful when running bin/start -d, just pass args to docker-compose.
@vavgustov

This comment has been minimized.

Copy link
Member

vavgustov commented Feb 5, 2019

Thanks for your efforts! I'll check your pull requests at the end of the week.

@vavgustov vavgustov merged commit 8b1a89f into snibox:master Feb 9, 2019

@vavgustov

This comment has been minimized.

Copy link
Member

vavgustov commented Feb 9, 2019

Merged, thanks! Also I'll add a note about https://docs.docker.com/compose/reference/overview/ to README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment