[Improvement] Manage EOL date by setup eol_explicit status

[Robert-Azelis]

Description

This improvement allow setup EOL date manually by user on damand by set eol_explicit checkbox.

BEFORE:

AFTER:
If checkbox is not checked then EOL date is hiden and calculation of date is on the base Model EOL rate

If checkbox is checked then EOL date is showed and user can input EOL Date manually.
Status of checkbox is saved as eol_explicit value

In this way is much easier to manage EOL date and explicit marker status instead of build complex rules :)

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test Configuration:

• PHP version: 8.1
• MySQL version 10.6.5-MariaDB
• Webserver version IIS
• Web browser: MS Edge, Chrome

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[spencerrlongg]

Thanks for the PR! I think I see the advantage to this now.

Could we add some text to the checkbox explaining what it is? I think it'd be a little confusing as is. It could just say "Explicit" or something.

The one concern I have is if you check the box on an existing asset that has EOL months set on the model, the date box defaults to the calculated date (which makes sense) and then you can save an asset with eol_explicit set to true, even though it's the same as the calculated date. This could get a little confusing and defeat some of the purpose of the feature.

Could we do a diffInMonths() check to make sure that it's actually different before saving?

Thanks again!

[Robert-Azelis]

Hi, do you mean about something like this?

Could we do a diffInMonths() check to make sure that it's actually different before saving?
It is not good idea, in some cases purchase date could be not set, so cannot use diffInMonths() function.
Beside, if user decide to set explicit marker manually by enable checkbox and set EOL date (even if leave this same as it was calulated), then shuld be aware that EOL date is resistance to any furhter changes of asset model EOL rate and asset purchase date.
I think additionl check by diffInMonths() function is not neccesary.

Any changes are not yet done, let's make sure that we agree ;)

[spencerrlongg]

Yeah, I think that's more or less what I mean for the text.

We could still check if purchase_date is set and only do diffInMonths() if it has been, this way it's a little more obvious to the user when they select the option that the date is possibly still the same as the calculated date.

Not a hill I'm ready to die on though - I do see your point about being able to set it explicit to not change the eol_date so that you can change the model eol without updating specific assets.

[Robert-Azelis]

I'm sorry, by mistake updated my branch by master, not sure how to revert changes, so re-created this PR under new #13846