Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snips-dialogue] the configuration option to set the resources path does not work. #74

Closed
diplix opened this issue Dec 9, 2018 · 2 comments

Comments

@diplix
Copy link

commented Dec 9, 2018

there seems to be no way to alter the settings for confirmation_cancel_pattern, confirmation_yes_pattern, confirmation_no_pattern, general_misunderstanding or answer_misunderstanding contained in /usr/share/snips/assistant/custom_dialogue/speak/ because each sam update-assistant overwrites these files with some default settings.

this is especially annoying, because the german translation for general_misunderstanding or answer_misunderstanding is in formal german and not really appropriate for a personal assistant. it’s also a little long.

there is a resources setting in snips.toml that might be intended for this, but doesn’t work for me:

[snips-dialogue]
#resources = "/usr/share/snips/dialogue"
# session_timeout = 15
# lambda_timeout = 5
#retry_count = 1
#sound_feedback_enabled_default = true

even if i copy the /usr/share/snips/assistant/custom_dialogue folder to /usr/share/snips/dialogue and uncomment the resources line, still the language resources from /usr/share/snips/assistant/custom_dialogue/speak/de.json are used.

it would however probably best to configure these settings in the snips console? or snips.toml?

i would also suggest adding a stop to the conffirmation_cancel_pattern. below my suggestion for the german translations:

{
    "language": "de",
    "confirmation_cancel_pattern": "(?i)(?:\\W+|^)(?:stop|abbrechen|brich ab|verwerfen|zur[üu]cknehmen|annullieren|stornieren|r[üu]ckbuchen|widerrufen|zur[üu]ckziehen)(?:\\W+|$)",
    "confirmation_yes_pattern": "(?i)(?:\\W+|^)(?:ja|von mir aus|auf alle F[äa]lle|meinetwegen|auf jeden Fall|klar|unbedingt|absolut|einverstanden|passt|OK|sicher|bestimmt|joa)(?:\\W+|$)",
    "confirmation_no_pattern": "(?i)(?:\\W+|^)(nein|auf keinen Fall|na|nee)(?:\\W+|$)",
    "general_misunderstanding": "Das habe ich nicht verstanden",
    "answer_misunderstanding": "Ich habe die Antwort nicht verstanden"
}

@cpoisson cpoisson self-assigned this Mar 8, 2019

@cpoisson cpoisson added bug and removed support labels Mar 8, 2019

@cpoisson cpoisson added this to the Snips Flow - Next milestone Mar 8, 2019

@cpoisson cpoisson changed the title no way to configure /usr/share/snips/assistant/custom_dialogue/speak/xx.json [snips-dialogue] no way to configure /usr/share/snips/assistant/custom_dialogue/speak/xx.json Mar 8, 2019

@cpoisson

This comment has been minimized.

Copy link
Collaborator

commented Mar 8, 2019

@diplix

Thanks for your feedback, the issue is confirmed.

@cpoisson cpoisson changed the title [snips-dialogue] no way to configure /usr/share/snips/assistant/custom_dialogue/speak/xx.json [snips-dialogue] the configuration option to set the resources path does not work. Mar 8, 2019

@cpoisson cpoisson modified the milestones: Snips Flow - Next, Snips Flow - Release 1.1.3, Snips Flow - Release 1.1.2 Mar 12, 2019

@cpoisson

This comment has been minimized.

Copy link
Collaborator

commented Mar 20, 2019

Fixed on version 1.1.2 (0.62.2)

@cpoisson cpoisson closed this Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.