Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with the None intent when using the parse top_n API #781

Merged
merged 2 commits into from Apr 5, 2019

Conversation

adrienball
Copy link
Contributor

Description:
The None intent was ignored when using the parse API in conjunction with intents and top_n

Checklist:

  • My PR is ready for code review
  • I have added some tests, if applicable, and run the whole test suite, including linting tests
  • I have updated the documentation, if applicable

The `None` intent was ignored when using the `parse` API in conjunction with `intents` and `top_n`
@adrienball adrienball requested a review from ClemDoum April 5, 2019 14:58
@codecov-io
Copy link

Codecov Report

Merging #781 into develop will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #781      +/-   ##
===========================================
+ Coverage     88.1%   88.19%   +0.08%     
===========================================
  Files           76       76              
  Lines         4541     4541              
  Branches       871      871              
===========================================
+ Hits          4001     4005       +4     
+ Misses         403      401       -2     
+ Partials       137      135       -2

@adrienball adrienball merged commit acfb853 into develop Apr 5, 2019
@adrienball adrienball deleted the fix/top-n branch April 5, 2019 15:16
@adrienball adrienball mentioned this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants