Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represent filters in xlsx export better #35

Open
snotskie opened this issue Aug 22, 2023 · 0 comments
Open

Represent filters in xlsx export better #35

snotskie opened this issue Aug 22, 2023 · 0 comments
Labels
consensus needed Further information is requested enhancement New feature or request
Milestone

Comments

@snotskie
Copy link
Owner

Currently, unitFilter and friends are Functions. These are tricky to represent in plaintext in a spreadsheet cell in a language-agnostic way. We make do by storing the intermediate representatiom of the Julia function. But that makes importing the filter back in difficult, so from_xlsx hasn't been finished yet

One idea I have is to take a page from python and run SQL against the dataframes instead of using a function-based filter

That would give us a neat, language-agnostic, plaintext rep. The limitations though are:

  • requires being familiar with sql
  • possible performance drop
  • opens security vector through possible injections
  • limits functionality to what sql can represent
@snotskie snotskie added enhancement New feature or request consensus needed Further information is requested labels Aug 22, 2023
@snotskie snotskie added this to the 0.7.0 milestone Sep 14, 2023
@snotskie snotskie modified the milestones: 0.7.0, 0.8.0 Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus needed Further information is requested enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant