New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java builds and tests #6
Comments
I'd be happy to have a pull request for this. |
Yes, this would certainly be good to have.
|
@oerd Is this still something you're interested in working on? |
While testing a Java code generator tweak by hand, I discovered a number of latent issues, and quickly implemented a simple |
@ojwb sorry for the absence... work has me working on other things. |
This might be a long shot, but the main reason for the Java build and tests was to later include some improvements in the Java stemmers that might be of interest. |
I can't really given a generic pre-approval, but my aim is to merge changes which are generally useful. I'd suggest opening a separate PR once they're ready. |
Yeah, this is what I had in mind... not you accepting whatever came in 😄 |
The CI build now runs the java tests I added (8691223). @oerd You indicated you might have some better Java test code, and that I should assign this to you - I'm happy to leave it open, but if that code is lost for good, or doesn't add anything to what we now have, we might as well close this. (Further Java improvements welcome too of course, but that's not really part of this ticket). |
BTW, it seems I can't actually assign to you (in github terms), only to myself or rboulton. |
I'm going to close this ticket - the original issue was addressed over a year ago (CI builds now run Java tests). @oerd Better Java test code and/or improvements to the Java stemmers are certainly still of interest - please just open a PR for them if/when they're ready. |
Hi @rboulton ,
I would like the Java stemmers to also be included in travis-ci builds, ideally with stemming tests like it's C counterparts (see #5).
If it's alright with you, I'd like to work on this and submit a pull-request shortly.
oerd
The text was updated successfully, but these errors were encountered: