Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java builds and tests #6

Closed
oerd opened this issue Jun 13, 2014 · 11 comments
Closed

Java builds and tests #6

oerd opened this issue Jun 13, 2014 · 11 comments

Comments

@oerd
Copy link
Contributor

oerd commented Jun 13, 2014

Hi @rboulton ,

I would like the Java stemmers to also be included in travis-ci builds, ideally with stemming tests like it's C counterparts (see #5).

If it's alright with you, I'd like to work on this and submit a pull-request shortly.

oerd

@oerd oerd changed the title Java builds and test Java builds and tests Jun 13, 2014
@rboulton
Copy link
Member

I'd be happy to have a pull request for this.

@ojwb
Copy link
Member

ojwb commented Sep 4, 2015

Yes, this would certainly be good to have.

GNUmakefile currently doesn't have any code to try to actually build the generated java code, so probably the best approach is to add rules there to compile the java code and test it against snowball-data, then make .travis.yml run those rules.

@ojwb
Copy link
Member

ojwb commented Oct 1, 2015

@oerd Is this still something you're interested in working on?

@ojwb
Copy link
Member

ojwb commented Oct 4, 2015

While testing a Java code generator tweak by hand, I discovered a number of latent issues, and quickly implemented a simple check_java target to aid fixing them. I've committed this in 16f9cd4, as it seems better than not having anything.

@oerd
Copy link
Contributor Author

oerd commented Oct 4, 2015

@ojwb sorry for the absence... work has me working on other things.
That said, I have to dig up some code I used to test the Java stemmers some months back. I'll merge them after your commit.
You can assign this issue to me

@oerd
Copy link
Contributor Author

oerd commented Oct 4, 2015

This might be a long shot, but the main reason for the Java build and tests was to later include some improvements in the Java stemmers that might be of interest.

@ojwb
Copy link
Member

ojwb commented Oct 4, 2015

I can't really given a generic pre-approval, but my aim is to merge changes which are generally useful. I'd suggest opening a separate PR once they're ready.

@oerd
Copy link
Contributor Author

oerd commented Oct 4, 2015

Yeah, this is what I had in mind... not you accepting whatever came in 😄

@ojwb
Copy link
Member

ojwb commented Jan 20, 2016

The CI build now runs the java tests I added (8691223).

@oerd You indicated you might have some better Java test code, and that I should assign this to you - I'm happy to leave it open, but if that code is lost for good, or doesn't add anything to what we now have, we might as well close this.

(Further Java improvements welcome too of course, but that's not really part of this ticket).

@ojwb
Copy link
Member

ojwb commented Jan 20, 2016

BTW, it seems I can't actually assign to you (in github terms), only to myself or rboulton.

@ojwb
Copy link
Member

ojwb commented Feb 21, 2017

I'm going to close this ticket - the original issue was addressed over a year ago (CI builds now run Java tests).

@oerd Better Java test code and/or improvements to the Java stemmers are certainly still of interest - please just open a PR for them if/when they're ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants