Skip to content

Remove basetemp to test on windows #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 25, 2024
Merged

Remove basetemp to test on windows #1863

merged 5 commits into from
Jan 25, 2024
+1 −1

Conversation

@sfc-gh-yixie
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-yixie sfc-gh-yixie changed the title Use 'file://...' instead of file://... for integration tests Remove basetemp to test on windows Jan 25, 2024
@sfc-gh-yixie sfc-gh-yixie added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jan 25, 2024
@sfc-gh-yixie sfc-gh-yixie marked this pull request as ready for review January 25, 2024 00:30
@sfc-gh-yixie sfc-gh-yixie merged commit 96bb134 into main Jan 25, 2024
@sfc-gh-yixie sfc-gh-yixie deleted the yixie-try-file-single-quote branch January 25, 2024 02:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-jdu sfc-gh-jdu sfc-gh-jdu approved these changes

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

Assignees

No one assigned

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-yixie @sfc-gh-jdu @sfc-gh-aling