Fix validation failures #299
Comments
Can you put the full log of the testsuite somewhere? |
@nomeata I don't have the full log, but I attached the list of all failures to this comment. P.S.: This particular log was generated in the default build flavour, but the results are pretty similar to the |
Ah, this is on windows? How many of these are also on Linux? But without a full build log it is hard to see what’s going on. Maybe some linker error that affects Template Haskell and GHCi? |
@nomeata Yes, I develop on Windows and test Hadrian on Linux/OSX via CI only. Perhaps, you could try validating on Linux and share the log here? |
On my Linux machine for commit c158014 (GHC: 65b185d):
And some log: https://gist.github.com/izgzhen/a7b8bf3bce035432f5d8fd5605136062 |
Thanks @izgzhen! This looks similar to Windows stats above. |
A more recent result: Note that I found it is important to run
|
@izgzhen Thanks for the update! Reducing Indeed, it looks like there is a special flavour for validation. |
I suppose many of these were due to |
The latest result with
I think I shall drop the PR #422 for now, since I still haven't find any clear way to get a better validation result yet. |
Results generated in ubuntu 17.10 on 2nd March 2017:
Complete Summary: |
Thanks @chitrak7! Hope you'll be able to figure out the cause of some validation failures. |
@snowleopard 55 of 118 unexpected failures have come from printer/. But I seriously doubt it has something to do with my system configuration and not the build. Can you review their error log once to check this. I have attached the errorlog in the previous comment. |
@chitrak7 I don't think I can provide any useful comments on the validation log: I haven't looked into validation errors yet, so it's a completely new territory for me. |
@snowleopard for a lot of failures, the reason is that some executable is not present in inplace. For example, I think solving this might reduce a lot of errors |
@chitrak7 Aha, interesting! Presumably, these are only needed for the testsuite, so we didn't bother to build them before. We need to add missing packages here: https://github.com/snowleopard/hadrian/blob/master/src/GHC.hs#L45-L100 And also |
Yeah, would be a nice start. Would need some time and a lot of help though 😅 |
@chitrak7 Awesome, thanks. Happy to help! |
Results after adding missing executables:
|
@chitrak7 That's a very promising result! Can you prepare a PR? Furthermore, it looks like the remaining |
@snowleopard Currently I am trying to single out more libraries that are causing error. I have identified a couple more. I will try to bring the errors down to 20s and then send the PR. Need a couple more days. |
@chitrak7 No need to send just one perfect PR. In fact, sending a PR to only adds missing executables would be better, because it's easier to review and understand in isolation. |
I believe this issue is out of date, so closing. |
At the moment building GHC with Hadrian and then running
build validate
produces a lot of failures:In the list of unexpected failures the majority comes from
ghci
,perf
,printer
,profiling
,rts
,safeHaskell
andth
.Most probably cause is that the GHC we build is missing some features.
/cc: @bgamari @nomeata
The text was updated successfully, but these errors were encountered: