New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross compilation #401

Merged
merged 1 commit into from Aug 28, 2017

Conversation

Projects
None yet
2 participants
@izgzhen
Collaborator

izgzhen commented Aug 26, 2017

Tested with arm-linux-gnueabihf using https://gist.github.com/izgzhen/26e49e7bf2e79a9a8f0a3ec37e4837af

@izgzhen

This comment has been minimized.

Show comment
Hide comment
@izgzhen

izgzhen Aug 26, 2017

Collaborator

Still needs refining, but the current design choices are clear by themselves. What is your idea? @snowleopard

Collaborator

izgzhen commented Aug 26, 2017

Still needs refining, but the current design choices are clear by themselves. What is your idea? @snowleopard

Show outdated Hide outdated README.md
Show outdated Hide outdated src/GHC.hs
@snowleopard

This comment has been minimized.

Show comment
Hide comment
@snowleopard

snowleopard Aug 26, 2017

Owner

@izgzhen Awesome! I've left a few questions and suggestions in the code.

Owner

snowleopard commented Aug 26, 2017

@izgzhen Awesome! I've left a few questions and suggestions in the code.

@izgzhen

This comment has been minimized.

Show comment
Hide comment
@izgzhen

izgzhen Aug 27, 2017

Collaborator
Build system error - indirect recursion detected:
  Key value 1:  OracleQ (KeyValue ("hadrian/cfg/system.config","host-os"))
  Key value 2:  hadrian/cfg/system.config
  Key value 3:  hadrian/cfg/system.config settings mk/config.h
  Key value 4:  OracleQ (KeyValue ("hadrian/cfg/system.config","cross-compiling"))
Rules may not be recursive

Another problem caused by using Action Bool instead of Bool for crossCompiling....I'll use the pure version for now.

Collaborator

izgzhen commented Aug 27, 2017

Build system error - indirect recursion detected:
  Key value 1:  OracleQ (KeyValue ("hadrian/cfg/system.config","host-os"))
  Key value 2:  hadrian/cfg/system.config
  Key value 3:  hadrian/cfg/system.config settings mk/config.h
  Key value 4:  OracleQ (KeyValue ("hadrian/cfg/system.config","cross-compiling"))
Rules may not be recursive

Another problem caused by using Action Bool instead of Bool for crossCompiling....I'll use the pure version for now.

@snowleopard

This comment has been minimized.

Show comment
Hide comment
@snowleopard

snowleopard Aug 27, 2017

Owner

@izgzhen Sure, let's use Bool in the first implementation.

Owner

snowleopard commented Aug 27, 2017

@izgzhen Sure, let's use Bool in the first implementation.

Add cross compilation
Tested with arm-linux-gnueabihf.
@izgzhen

This comment has been minimized.

Show comment
Hide comment
@izgzhen

izgzhen Aug 28, 2017

Collaborator

updated the code

Collaborator

izgzhen commented Aug 28, 2017

updated the code

@snowleopard

This comment has been minimized.

Show comment
Hide comment
@snowleopard

snowleopard Aug 28, 2017

Owner

@izgzhen Thank you, looks good. Shall I merge?

Owner

snowleopard commented Aug 28, 2017

@izgzhen Thank you, looks good. Shall I merge?

@izgzhen

This comment has been minimized.

Show comment
Hide comment
@izgzhen

izgzhen Aug 28, 2017

Collaborator
Collaborator

izgzhen commented Aug 28, 2017

@snowleopard snowleopard merged commit cbc2f63 into snowleopard:master Aug 28, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@snowleopard

This comment has been minimized.

Show comment
Hide comment
@snowleopard

snowleopard Aug 28, 2017

Owner

@izgzhen Sounds good! I've merged this and we can continue via a few more patches.

Owner

snowleopard commented Aug 28, 2017

@izgzhen Sounds good! I've merged this and we can continue via a few more patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment