Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: consider adding custom formats for JSON Schemas #170

Open
chuwy opened this issue Jul 18, 2016 · 3 comments
Open

Common: consider adding custom formats for JSON Schemas #170

chuwy opened this issue Jul 18, 2016 · 3 comments
Milestone

Comments

@chuwy
Copy link
Contributor

chuwy commented Jul 18, 2016

Until now I mistakenly thought that formats property must be equal to one of predefined formats (uuid, ipv4 etc), but I just found out that it may be a custom property. Actual implementation of this property is on the client app's (iglu-client, igluctl) behalf.

We already implemented Library interface (fge schema validator's entity responsible for adding custom properties and formats) for a self property, on top of draft v4. May be we want to add new formats to it as well? Something iglu-specific? (not supporting implementations must skip it) jsonpath, schemaver, schemaCriterion?

@alexanderdean any thoughts? Do we need it?

Also I think what lib this Library (~100 LOC javaish class) should belong to. It should be shared among at least igluctl and Iglu client, but client now uses duller approach with catching exceptions. DDL AST is probably best option.

@alexanderdean
Copy link
Member

Interesting! Where does this Library live today?

@chuwy
Copy link
Contributor Author

chuwy commented Jul 18, 2016

In igluctl.

@alexanderdean alexanderdean added this to the Far-out stuff milestone Jul 18, 2016
@alexanderdean
Copy link
Member

Cool, have put this into the Far-out stuff milestone for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants