From 0f3fb813220ce37cac042685eb875b041cff0ba1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matu=CC=81s=CC=8C=20Tomlein?= Date: Wed, 21 Feb 2024 09:30:33 +0100 Subject: [PATCH] Remove deprecated setMockMethodCallHandler from tests (close #41) --- .github/workflows/build.yml | 10 +++++----- .github/workflows/publish.yml | 2 +- test/snowplow_test.dart | 6 ++++-- test/tracker_test.dart | 6 ++++-- 4 files changed, 14 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 43515dc..1fee131 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -6,7 +6,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - flutter: ['3.0.0'] + flutter: ['3.19.0'] steps: - uses: actions/checkout@v2 - uses: subosito/flutter-action@v1 @@ -23,7 +23,7 @@ jobs: - uses: actions/checkout@v2 - uses: subosito/flutter-action@v1 with: - flutter-version: '3.0.0' + flutter-version: '3.19.0' channel: 'stable' - run: flutter pub get - run: flutter analyze @@ -60,7 +60,7 @@ jobs: # -- Integration tests -- - uses: subosito/flutter-action@v1 with: - flutter-version: '3.0.0' + flutter-version: '3.19.0' channel: 'stable' - name: Run Flutter Driver tests @@ -108,7 +108,7 @@ jobs: - uses: subosito/flutter-action@v1 with: - flutter-version: '3.0.0' + flutter-version: '3.19.0' channel: 'stable' - run: "flutter clean" @@ -146,7 +146,7 @@ jobs: # -- Integration tests -- - uses: subosito/flutter-action@v1 with: - flutter-version: '3.0.0' + flutter-version: '3.19.0' channel: 'stable' - run: chromedriver --port=4444 & diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 4ef2c24..5da4b0a 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - flutter: ['3.0.0'] + flutter: ['3.19.0'] steps: - uses: actions/checkout@v2 - uses: subosito/flutter-action@v1 diff --git a/test/snowplow_test.dart b/test/snowplow_test.dart index def977c..788d4ba 100644 --- a/test/snowplow_test.dart +++ b/test/snowplow_test.dart @@ -38,14 +38,16 @@ void main() { setUp(() { methodCall = null; returnValue = null; - channel.setMockMethodCallHandler((MethodCall call) async { + TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger + .setMockMethodCallHandler(channel, (MethodCall call) async { methodCall = call; return returnValue; }); }); tearDown(() { - channel.setMockMethodCallHandler(null); + TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger + .setMockMethodCallHandler(channel, (message) => null); }); test('createsTrackerWithConfiguration', () async { diff --git a/test/tracker_test.dart b/test/tracker_test.dart index ee40d28..7e1b61f 100644 --- a/test/tracker_test.dart +++ b/test/tracker_test.dart @@ -27,7 +27,8 @@ void main() { setUp(() async { returnValue = null; - channel.setMockMethodCallHandler((MethodCall methodCall) async { + TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger + .setMockMethodCallHandler(channel, (MethodCall methodCall) async { method = methodCall.method; arguments = methodCall.arguments; return returnValue; @@ -39,7 +40,8 @@ void main() { }); tearDown(() { - channel.setMockMethodCallHandler(null); + TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger + .setMockMethodCallHandler(channel, null); }); test('tracks structured event', () async {