Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.6.1 #197

Open
wants to merge 11 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@oguzhanunlu
Copy link
Collaborator

commented Jun 3, 2019

No description provided.

@oguzhanunlu oguzhanunlu added this to the Version 0.6.1 milestone Jun 3, 2019

@oguzhanunlu oguzhanunlu self-assigned this Jun 3, 2019

@oguzhanunlu oguzhanunlu requested a review from BenFradet Jun 3, 2019

@BenFradet
Copy link
Member

left a comment

a couple of qs but that looks good overall

Show resolved Hide resolved go.sum
Show resolved Hide resolved provisioning/roles/sp_mini_3_build_go_projects/tasks/main.yml Outdated

@oguzhanunlu oguzhanunlu force-pushed the v0.6.1 branch 4 times, most recently from 52f178d to b5969ae Jun 5, 2019

@oguzhanunlu oguzhanunlu force-pushed the v0.6.1 branch 15 times, most recently from 74db517 to 1c8f744 Jun 11, 2019

@oguzhanunlu oguzhanunlu force-pushed the v0.6.1 branch 18 times, most recently from c1d5785 to b6ab536 Jun 18, 2019

@oguzhanunlu oguzhanunlu requested a review from BenFradet Jun 20, 2019

@oguzhanunlu

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 20, 2019

hey @BenFradet , I needed to include additional work and update some existing commits after your review. Do you mind taking another look at the PR? I also published 0.6.1-rc1 to both AWS & GCP.

@BenFradet
Copy link
Member

left a comment

Looks good 👍, does the BIN.enc file need to be in the repo?

@oguzhanunlu

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 21, 2019

Thanks @BenFradet , yes, we've changed the way we publish artifacts, the process is moved to Travis and BIN.enc is an encrypted file which is decrypted during build process and used by Packer when publishing to GCP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.