Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Stream Collector: allow multiple cookie domains to be used #3994

Open
BenFradet opened this issue Feb 22, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@BenFradet
Copy link
Member

commented Feb 22, 2019

The idea, if I got it right, would be to investigate the content of the Origin header and send back a Set-Cookie with the corresponding domain, e.g.:

collector.cookie {
    enabled = true
    expiration =  365 days"
    name = cookie
    domains = {
      "snowplowanalytics.com" = ".snplow.com"
      "other-domain.com" = ".something-else.com"
      // we could have a fallback / catch all here
    }
}

cc @jbeemster

@szareiangm

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

This is very interesting and something that we are interested, too. Has anyone started working on it?

what is your suggested fallback? like a default domain? how about mirroring whatever domain that they come from?

@BenFradet

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

No, no one has started on this yet.

Regarding the fallback I think we'd want to mirror the existing functionality to avoid breakage.

how about mirroring whatever domain that they come from?

I think this would constitute a security liability.

dilyand added a commit that referenced this issue Jun 6, 2019

@dilyand dilyand changed the title Scala Stream Collector: explore custom mappings for cookie domain Scala Stream Collector: allow multiple cookie domains to be used Jun 11, 2019

@chuwy chuwy modified the milestones: RX (SSC), R116 Madara Rider Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.