Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 'Unknown' deviceClass to ensure deviceClass enum validates #4114 #4115

wants to merge 1 commit into
base: master


None yet
4 participants
Copy link

commented Jul 3, 2019

Addresses #4114 by returning Unknown instead of UNKNOWN which fails schema validation for the deviceClass.

@BenFradet BenFradet requested a review from benjben Jul 3, 2019

Copy link

left a comment

Thanks 👍


This comment has been minimized.

Copy link

commented Jul 3, 2019

@miike has signed the Software Grant and Corporate Contributor License Agreement

@snowplowcla snowplowcla added the cla:yes label Jul 3, 2019


benjben approved these changes Jul 3, 2019

Copy link

left a comment

Sorry for the mistake. Thanks a lot for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.