New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapAccum and mapAccumM should be strict in their state #218

Closed
ndmitchell opened this Issue Jul 23, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@ndmitchell
Contributor

ndmitchell commented Jul 23, 2015

That seems reasonable to expect, given that foldM works that way.

@snoyberg

This comment has been minimized.

Owner

snoyberg commented Jul 23, 2015

Agreed. Can you send a PR? I'm not at my computer now.

@snoyberg

This comment has been minimized.

Owner

snoyberg commented Jul 23, 2015

Got to a computer faster than I thought I would. If you want me to add this, no problem, just let me know.

@ndmitchell

This comment has been minimized.

Contributor

ndmitchell commented Jul 23, 2015

I'll have a pull request with you in a few mins.

@ndmitchell

This comment has been minimized.

Contributor

ndmitchell commented Jul 23, 2015

@snoyberg snoyberg closed this in de53a2f Jul 23, 2015

@snoyberg

This comment has been minimized.

Owner

snoyberg commented Jul 23, 2015

Thanks. Uploaded as 1.2.5.

@ndmitchell

This comment has been minimized.

Contributor

ndmitchell commented Aug 8, 2015

I made this change because it seemed like the right thing to do. I've just spent two hours tracking down a Hoogle space leak that was only exhibiting on some machines (specifically the real Hoogle server) and not others (my development machine). Turned out to be entirely down to a not-strict accumulator which due to the old version of conduit was causing issues. Just shows that accumulators should definitely be strict!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment