Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a non-throwing version of 'sinkParser' #189

Merged
merged 1 commit into from Dec 11, 2014

Conversation

@rjmac
Copy link
Contributor

commented Dec 10, 2014

It can be convenient to feed a conduit into a parser without dragging in the exception machinery.

I don't know if you'll like the way I added it to the tests -- it sort of violates the "a test should test only one thing" rule, but there was also much less duplication this way. I can re-do that if you prefer.

@snoyberg snoyberg merged commit df90ff4 into snoyberg:master Dec 11, 2014

@snoyberg

This comment has been minimized.

Copy link
Owner

commented Dec 11, 2014

Looks good. Now on Hackage as 1.1.5.

@snoyberg

This comment has been minimized.

Copy link
Owner

commented Dec 11, 2014

And thanks for the addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.